948622 - Improve activate_edit_mode()

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Zac C (:zac)]

The locator in this is horrible!

Let's try and simplify it down to something that we can trust a bit more.

If possible improve the wait for it to get into edit mode too.

This affects the tests:
test_homescreen_edit_mode.py
test_homescreen_delete_app.py
test_homescreen_move_app.py

Comment 1

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/14612

Comment 2

[[:AndreiH]]

Comment on attachment 8346546 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14612

This works ok on device, but I am going to r- this because test_homescreen_delete_app fails on desktop locally and on Travis.
Also nth-child is a to risky locator

Comment 3

[Trif Andrei-Alin[:AlinT]]

Comment on attachment 8346546 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14612

please improve "_visible_icons_locator"
https://github.com/mozilla-b2g/gaia/pull/14612#discussion-diff-8368374R17

Comment 4

[Florin Strugariu [:Bebe]]

Comment on attachment 8346546 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14612

Change back that locator to use "translateX(0px);"

Comment 5

[Zac C (:zac)]

Comment on attachment 8346546 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14612

r+

Comment 6

[Trif Andrei-Alin[:AlinT]]

Comment on attachment 8346546 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14612

r+

Comment 7

[Trif Andrei-Alin[:AlinT]]

Merged in:
https://github.com/mozilla-b2g/gaia/commit/6835be8ffabed18dd7d4eca2b69c5aa7afda8dc8