Closed
Bug 948819
Opened 12 years ago
Closed 12 years ago
[MediaEncoder] Remove the current implementation of rounding odd size video resolutions
Categories
(Core :: Audio/Video: Recording, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: shelly, Assigned: shelly)
References
(Blocks 1 open bug)
Details
(Whiteboard: [ft:multimedia-platform])
Attachments
(1 file, 1 obsolete file)
|
1.23 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Remove the current implementation of rounding odd size video resolutions before creating the codec encoder.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8345776 [details] [diff] [review]
Don't round the odd size resolution when creating encoder
Review of attachment 8345776 [details] [diff] [review]:
-----------------------------------------------------------------
For the odd framesize problem, We think we should have a filter to do the resize, crop stuff.
Remove this adjust and have patch on bug:948815.
Attachment #8345776 -
Flags: review?(roc)
Attachment #8345776 -
Flags: feedback+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Future discussion and implementation about how to handle frame resolutions not supported by codec, should be in bug 948815. But for now, I think we should at least remove the in-correct implementation.
Attachment #8345776 -
Attachment is obsolete: true
Attachment #8345776 -
Flags: review?(roc)
Attachment #8345781 -
Flags: review?(roc)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → slin
Attachment #8345781 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
Whiteboard: [ft:multimedia-platform]
|
||
Comment 4•12 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
||
Updated•11 years ago
|
Component: Video/Audio → Video/Audio: Recording
You need to log in
before you can comment on or make changes to this bug.
Description
•