Closed Bug 948829 Opened 6 years ago Closed 6 years ago

Temporarily disable Nuwa until about:memory fixed.

Categories

(Core :: IPC, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29
blocking-b2g 1.3+
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
b2g-v1.3 --- fixed

People

(Reporter: kk1fff, Assigned: kk1fff)

References

Details

Attachments

(1 file)

See discussion in bug 930282 comment 53 and 54. As nuwa introduced some regressions, we disable nuwa temporarily before about:memory on b2g is fixed.
Attachment #8345726 - Flags: review?(khuey)
(In reply to Patrick Wang [:kk1fff] from comment #0)
> Created attachment 8345726 [details] [diff] [review]
> Patch: disable nuwa
> 
> See discussion in bug 930282 comment 53 and 54. As nuwa introduced some
> regressions, we disable nuwa temporarily before about:memory on b2g is fixed.

So US is currently sleeping right now - is there anyone else that can review this on the Taipei side in order to get this landed before US wakes up? It would be great if we could get this in before the next nightly build is generated for 1.3 & 1.4.
This didn't really need to be reviewed.
Summary: Temporarily Nuwa before about:memory fixed. → Temporarily disable Nuwa until about:memory fixed.
https://hg.mozilla.org/mozilla-central/rev/351990c63a98
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
That patch didn't work for me, I had to do that:

diff --git a/b2g/confvars.sh b/b2g/confvars.sh
--- a/b2g/confvars.sh
+++ b/b2g/confvars.sh
@@ -52,13 +52,13 @@ MOZ_TIME_MANAGER=1
 
 MOZ_B2G_CERTDATA=1
 MOZ_PAY=1
 MOZ_TOOLKIT_SEARCH=
 MOZ_PLACES=
 MOZ_B2G=1
 
 if test "$OS_TARGET" = "Android"; then
-MOZ_NUWA_PROCESS=0
+MOZ_NUWA_PROCESS=
 fi
 MOZ_FOLD_LIBS=1
 
 MOZ_JSDOWNLOADS=1
Ah, yes. It's my fault, I forgot build script tests MOZ_NUWA_PROCESS as text.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/a9bd2a15f61f
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.