948851 - Get toolkit/crashreporter's CrashTestUtils.jsm out of EXTRA_JS_MODULES

Status: RESOLVED DUPLICATE of bug 1044162

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

CrashTestUtils.jsm is the lone instance of EXTRA_JS_MODULES in Makefile.in remaining in the tree. We should deal with it and add EXTRA_JS_MODULES to the ban list in config.mk.

Comment 1

[Gregory Szorc [:gps]]

The easy way is to move this to support-files. Slightly harder way involves changing CrashTestUtils.jsm to a testing-only JSM. I don't feel like digging into the bowels of crashreporter's tests.

Comment 2

[(not currently active) Ted Mielczarek]

Moving it to a testing-only JSM is the right way. This should be a mostly-trivial change, it's only actually imported directly in two files:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/test/unit/crasher_subprocess_head.js#28
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/test/unit/head_crashreporter.js#148

The only tricky bit here is that CrashTestUtils.jsm wants to locate and load the testcrasher library using js-ctypes:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/test/CrashTestUtils.jsm#28

So it has to be able to locate that shared library. Currently it just relies on it being in the current working directory. We could feasibly stick the sharedlib into the modules directory alongside the jsm and use __LOCATION__ to find it.

Comment 3

[Nathan Froyd [:froydnj]]

CrashTestUtils.jsm got moved into moz.build in bug 880245...well before this bug got filed.  What is this bug about, then, exactly?

Comment 4

[Gregory Szorc [:gps]]

It's about killing the EXTRA_JS_MODULES reference in toolkit/crashreporter/test/Makefile.in. I /think/ this is a simple support-files addition in an xpcshell.ini.

Comment 5

[Gregory Szorc [:gps]]

Looks like this got addressed in b961ba8f0892.