Closed Bug 948866 Opened 6 years ago Closed 6 years ago
[Window Management] Homescreen open transition sometimes is losing
STR: 1. Open app 2. Press home button Actual: Sometimes homescreen app transition of opening is losing. (But app closing transition works)
Assignee: nobody → alive
WIP https://github.com/mozilla-b2g/gaia/pull/14601 Adding unit tests.
Attachment #8346499 - Flags: review?(etienne)
Comment on attachment 8346499 [details] [review] https://github.com/mozilla-b2g/gaia/pull/14601 The code change looks good, but still some stuff to discuss: * changing the scale to 3 looks better to me, but we should bikeshed with designers :) * the opacity performance issue * the fact that we need test for the homescreen specific use cases in AppWindow, but this can be a follow up. And mainly, I think there's a reflow somewhere near the end of the transition, I'd like to hunt it. But the devtools are broken for me right now, working on it.
Attachment #8346499 - Flags: review?(etienne) → feedback+
Comment on attachment 8346499 [details] [review] https://github.com/mozilla-b2g/gaia/pull/14601 I spent some time with this patch again. My issue was with the scale of the transition changing from [0.01 to 1] to [0.2 to 1], not a reflow! r=me with the opacity change removed from the openApp animation and the scaling starting from 0.01 again (or was this causing an issue? :/). I did a bunch of edge case testing where I would kill the homescreen, everything works fine :)
Attachment #8346499 - Flags: review+
Addressed but travis is sleeping now...
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.