948936 - [marketplace-tests] Fix Marketplace tests fail object has no attribute 'install_marketplace'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Florin Strugariu [:Bebe]]

All of the 11 tests are currently failing with the following stack:

Traceback (most recent call last):
File "/var/jenkins/workspace/b2g.inari.mozilla-b2g26_v1_2.marketplace/.env/local/lib/python2.7/site-packages/marionette_client-0.6.2-py2.7.egg/marionette/marionette_test.py", line 127, in run
self.setUp()
File "/var/jenkins/workspace/b2g.inari.mozilla-b2g26_v1_2.marketplace/marketplacetests/tests/test_marketplace_add_review.py", line 19, in setUp
self.install_marketplace()
AttributeError: 'TestMarketplaceAddReview' object has no attribute 'install_marketplace'

Comment 1

[Florin Strugariu [:Bebe]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/marketplace-tests-gaia/pull/6#attch-to-bugzilla

Pointer to Github pull-request

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8345875 [details]
Pointer to Github pull request: https://github.com/mozilla/marketplace-tests-gaia/pull/6#attch-to-bugzilla

This looks okay, but I've not run the tests. r- because of a leftover dict.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8345875 [details]
Pointer to Github pull request: https://github.com/mozilla/marketplace-tests-gaia/pull/6#attch-to-bugzilla

Changes have been squashed since my last review so it's hard to see that only my suggested changes have been made. We should avoid squashing until we're ready to merge. Anyway r+ but as before I have not run these tests.

Comment 4

[Bob Silverberg [:bsilverberg]]

It looks like the PR was merged [1]. Is there a reason this bug is still open?

[1] https://github.com/mozilla/marketplace-tests-gaia/commit/23d93d0bda363bdacc20137f2a74cbf8446de289

Comment 5

[[:AndreiH]]

I don't think so.
Closing this bug as the pull was merged