Closed
Bug 948940
Opened 11 years ago
Closed 11 years ago
Merge test_fm add_to_favorite and test_fm_remove_favorite
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zcampbell, Assigned: viorela)
Details
Attachments
(1 file)
These two test cases are almost identical so let's remove them.
|
Reporter | |
Updated•11 years ago
|
Priority: -- → P4
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8347236 -
Flags: review?(zcampbell)
Attachment #8347236 -
Flags: review?(florin.strugariu)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → viorela.ioia
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8347236 [details] [review] Github PR: https://github.com/mozilla-b2g/gaia/pull/14652 something is fishy with the commit and pull name
Attachment #8347236 -
Flags: review?(florin.strugariu) → review-
|
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8347236 [details] [review] Github PR: https://github.com/mozilla-b2g/gaia/pull/14652 Some nitpicks I put in github pr but functionally it is fine.
Attachment #8347236 -
Flags: review?(zcampbell) → review-
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8347236 -
Flags: review?(zcampbell)
Attachment #8347236 -
Flags: review?(florin.strugariu)
Attachment #8347236 -
Flags: review-
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8347236 -
Flags: review?(trifandreialin)
|
|
||
Updated•11 years ago
|
Attachment #8347236 -
Flags: review?(florin.strugariu) → review+
|
|
Reporter | |
Comment 4•11 years ago
|
||
Comment on attachment 8347236 [details] [review] Github PR: https://github.com/mozilla-b2g/gaia/pull/14652 r+
Attachment #8347236 -
Flags: review?(zcampbell) → review+
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8347236 [details] [review] Github PR: https://github.com/mozilla-b2g/gaia/pull/14652 r+
Attachment #8347236 -
Flags: review?(trifandreialin) → review+
|
|
||
Comment 6•11 years ago
|
||
Merged in: https://github.com/mozilla-b2g/gaia/commit/ad673f483a88b8a4404ae0cdfc6946ac1b357cda
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•