Merge test_fm add_to_favorite and test_fm_remove_favorite

RESOLVED FIXED

Status

P4
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: zcampbell, Assigned: viorela)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
These two test cases are almost identical so let's remove them.
(Reporter)

Updated

5 years ago
Priority: -- → P4
(Assignee)

Comment 1

5 years ago
Created attachment 8347236 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14652
Attachment #8347236 - Flags: review?(zcampbell)
Attachment #8347236 - Flags: review?(florin.strugariu)
(Assignee)

Updated

5 years ago
Assignee: nobody → viorela.ioia
Comment on attachment 8347236 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14652

something is fishy with the commit and pull name
Attachment #8347236 - Flags: review?(florin.strugariu) → review-
(Reporter)

Comment 3

5 years ago
Comment on attachment 8347236 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14652

Some nitpicks I put in github pr but functionally it is fine.
Attachment #8347236 - Flags: review?(zcampbell) → review-
(Assignee)

Updated

5 years ago
Attachment #8347236 - Flags: review?(zcampbell)
Attachment #8347236 - Flags: review?(florin.strugariu)
Attachment #8347236 - Flags: review-
(Assignee)

Updated

5 years ago
Attachment #8347236 - Flags: review?(trifandreialin)
Attachment #8347236 - Flags: review?(florin.strugariu) → review+
(Reporter)

Comment 4

5 years ago
Comment on attachment 8347236 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14652

r+
Attachment #8347236 - Flags: review?(zcampbell) → review+
Comment on attachment 8347236 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14652

r+
Attachment #8347236 - Flags: review?(trifandreialin) → review+
Merged in:
https://github.com/mozilla-b2g/gaia/commit/ad673f483a88b8a4404ae0cdfc6946ac1b357cda
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.