Closed Bug 948974 Opened 12 years ago Closed 12 years ago

Sync 'Recovery key' field is not case sensitive

Categories

(Firefox for Android Graveyard :: Android Sync, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: cos_flaviu, Unassigned)

Details

Environment: Device: Google Nexus 7 (Android 4.4) Build: Nightly 29.0a1 (2013-12-10) Steps to reproduce: 1. Go Settings -> Sync -> Advanced Setup; 2. Fill the 'Account Name' and 'Password' fieds with valid account and password; 3. Fill the 'Recovery Key' field with a valid recovery key but using upper case characters; 4. Tap on 'Connect' button. Expected result: The following toast notification appear: 'Recovery Key incorrect. Please try again' Actual result: Sync setup is successfully complete because 'Recovery Key' field is not case sensitive.
Component: General → Android Sync
Product: Firefox for Android → Android Background Services
Version: Trunk → unspecified
IIRC, this is by design. Sync uses a "friendly" alphabet that removes O and 0 (letter and numeral), removes a few other easily mistaken letters, and is case insensitive. I think we get about 32 characters that way. rnewman, do you agree?
Flags: needinfo?(rnewman)
public static byte[] decodeFriendlyBase32(String base32) { Base32 converter = new Base32(); final String translated = base32.replace('8', 'l').replace('9', 'o'); return converter.decode(translated.toUpperCase()); } Please reopen if you see different *behavior* when using differently cased keys.
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(rnewman)
Resolution: --- → INVALID
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.