GenerationalGC: Browser build errors on Windows

RESOLVED FIXED in mozilla29

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

unspecified
mozilla29
All
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Currently Windows browser builds with GGC fail like this:

c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\jsweakmap.h(185) : error C2665: 'js::gc::IsMarked' : none of the 4 overloads could convert all the argument types
        c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\gc/Marking.h(306): could be 'bool js::gc::IsMarked(js::BarrieredValue *)'
        c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\gc/Marking.h(314): or       'bool js::gc::IsMarked(js::BarrieredPtrObject *)'
        c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\gc/Marking.h(320): or       'bool js::gc::IsMarked(js::BarrieredPtrScript *)'
        c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\jit/IonCode.h(748): or       'bool js::gc::IsMarked(const js::jit::VMFunction *)'
        while trying to match the argument list '(JSObject **)'
        c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\jsweakmap.h(180) : while compiling class template member function 'bool js::WeakMap<Key,Value>::markIteratively(JSTracer *)'
        with
        [
            Key=JSObject *,
            Value=JSObject *
        ]
        c:/builds/moz2_slave/try-w32-d-00000000000000000000/build/js/src/vm/ScopeObject.cpp(1542) : see reference to class template instantiation 'js::WeakMap<Key,Value>' being compiled
        with
        [
            Key=JSObject *,
            Value=JSObject *
        ]
c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\jsweakmap.h(197) : error C2228: left of '.unsafeSet' must have class/struct/union
        type is 'JSObject *'
        did you intend to use '->' instead?
Here's a patch.  This is pretty unpleasant though.
Assignee: nobody → jcoppeard
This is fallout from bug 944040.
Blocks: 944040
Attachment #8346034 - Flags: review?(terrence)
Comment on attachment 8346034 [details] [diff] [review]
weakmap-build-error

Review of attachment 8346034 [details] [diff] [review]:
-----------------------------------------------------------------

That is appalling, but if it works.... r=me
Attachment #8346034 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/e665842a7e10
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.