949038 - GenerationalGC: Browser build errors on Windows

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Jon Coppeard (:jonco)]

Currently Windows browser builds with GGC fail like this:

c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\jsweakmap.h(185) : error C2665: 'js::gc::IsMarked' : none of the 4 overloads could convert all the argument types
        c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\gc/Marking.h(306): could be 'bool js::gc::IsMarked(js::BarrieredValue *)'
        c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\gc/Marking.h(314): or       'bool js::gc::IsMarked(js::BarrieredPtrObject *)'
        c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\gc/Marking.h(320): or       'bool js::gc::IsMarked(js::BarrieredPtrScript *)'
        c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\jit/IonCode.h(748): or       'bool js::gc::IsMarked(const js::jit::VMFunction *)'
        while trying to match the argument list '(JSObject **)'
        c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\jsweakmap.h(180) : while compiling class template member function 'bool js::WeakMap<Key,Value>::markIteratively(JSTracer *)'
        with
        [
            Key=JSObject *,
            Value=JSObject *
        ]
        c:/builds/moz2_slave/try-w32-d-00000000000000000000/build/js/src/vm/ScopeObject.cpp(1542) : see reference to class template instantiation 'js::WeakMap<Key,Value>' being compiled
        with
        [
            Key=JSObject *,
            Value=JSObject *
        ]
c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\js\src\jsweakmap.h(197) : error C2228: left of '.unsafeSet' must have class/struct/union
        type is 'JSObject *'
        did you intend to use '->' instead?

Comment 1

[Jon Coppeard (:jonco)]

Attachment: weakmap-build-error

Here's a patch.  This is pretty unpleasant though.

Comment 2

[Jon Coppeard (:jonco)]

This is fallout from bug 944040.

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8346034 [details] [diff] [review]
weakmap-build-error

Review of attachment 8346034 [details] [diff] [review]:
-----------------------------------------------------------------

That is appalling, but if it works.... r=me

Comment 4

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e665842a7e10

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e665842a7e10