Closed
Bug 949184
Opened 12 years ago
Closed 12 years ago
Collect UITelemetry on icon size and button mode for toolbars
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Future
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Whiteboard: [Australis:P-][fixed-in-holly][Non-Australis-Only][qa-])
Attachments
(1 file)
|
1.23 KB,
patch
|
jaws
:
review+
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Summary says it all.
| Assignee | ||
Comment 1•12 years ago
|
||
I think it's this straight-forward.
Attachment #8346202 -
Flags: review?(jaws)
Updated•12 years ago
|
Attachment #8346202 -
Flags: review?(jaws) → review+
Updated•12 years ago
|
Whiteboard: [Australis:P-]
| Assignee | ||
Comment 2•12 years ago
|
||
Thanks - landed on Holly as: https://hg.mozilla.org/projects/holly/rev/09e16b04a3fb
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P-] → [Australis:P-][fixed-in-holly]
| Assignee | ||
Comment 3•12 years ago
|
||
Argh, shouldn't have closed this one - needs to remain open for the mozilla-central port.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
| Assignee | ||
Comment 4•12 years ago
|
||
And nope, I spaz'd out. This bug *should* be closed because there *is* no icon mode or button mode on mozilla-central.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P-][fixed-in-holly] → [Australis:P-][fixed-in-holly][Non-Australis-Only]
Updated•12 years ago
|
Target Milestone: --- → Future
| Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 8346202 [details] [diff] [review]
Patch v1
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
None. Gives BrowserUITelemetry the capability of recording a user's icon size and button mode (icons, text, icons+text) in their TelemetryPing.
User impact if declined:
None.
Testing completed (on m-c, etc.):
All manual at this point.
Risk to taking this patch (and alternatives if risky):
Very low.
String or IDL/UUID changes made by this patch:
None.
Attachment #8346202 -
Flags: approval-mozilla-beta?
Attachment #8346202 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #8346202 -
Flags: approval-mozilla-beta?
Attachment #8346202 -
Flags: approval-mozilla-beta+
Attachment #8346202 -
Flags: approval-mozilla-aurora?
Attachment #8346202 -
Flags: approval-mozilla-aurora+
| Assignee | ||
Comment 6•12 years ago
|
||
Landed in mozilla-beta as https://hg.mozilla.org/releases/mozilla-beta/rev/68a00e0e5d33
status-firefox27:
--- → fixed
| Assignee | ||
Comment 7•12 years ago
|
||
Landed in mozilla-aurora as https://hg.mozilla.org/releases/mozilla-aurora/rev/69a28e540c9b
status-firefox28:
--- → fixed
This fix will not be manually verified by QA. If you believe this warrants extra QA attention please nominate for testing by removing this whiteboard tag and adding the verifyme keyword. Please also provide any details you have that may inform our testing.
Whiteboard: [Australis:P-][fixed-in-holly][Non-Australis-Only] → [Australis:P-][fixed-in-holly][Non-Australis-Only][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•