949191 - [B2G][Browser] unknown cert issuer error message text overlaps the border and the text's letters are too small to read it

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[sarsenyev]

Attachment: 2013-12-11-14-00-28.png

Description:
When opening the unknown cert issuer page, some text is overlapped

Repro Steps:
1) Updated Buri to BuildID: 20131210004003
2) Open the "Browser" app from the home screen
3) Tap on the URL bar and type: https://cav.receita.fazenda.gov.br/eCAC/Aplicacao.aspx in the browser
4) Observe the text

Actual:
Some text is overlapped

Expected:
The text is not overlapped

Environmental Variables:
Device: Buri 1.3 Aurora Moz RIL
BuildID: 20131210004003
Gaia: 3452fbdb5e1bed0cd27cc6173136537a03e8072f
Gecko: e0c328d99742
Version: 28.0a2
Firmware Version: v1.2_20131115

Notes:
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/cases/?filter-id=6901
See attached: screenshot

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.1 or 1.2?

Comment 2

[sarsenyev]

Attachment: 2013-12-12-10-49-11.png(previous error page design)

It doesn't reproduce on 1.1 and 1.2 builds, because the design is changed see the attachment

Device: Buri 1.2 Moz RIL
BuildID: 20131211004007
Gaia: 096722a9e2510ecdfe45ba7382d7d50826b82feb
Gecko: 43d7b300241a
Version: 26.0
Firmware Version: v1.2_20131115

Device: Buri 1.1 Moz RIL
BuildID: 20131210041202
Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f
Gecko: 05117f42088f
Version: 18.0
Firmware Version: V1.2_20131115

Comment 3

[Jason Smith [:jsmith]]

I think I know what happened here - we might be rendering the desktop design here, rather than the mobile design. This is likely a regression then from bug 882186.

Comment 4

[[:fabrice] Fabrice Desré]

Attachment: wip

We erroneously removed the override for netError.css that is used by certError.xhtml.
This patch reverts this change, but for some unknown reason we still get a mostly unstlyled page.

Comment 5

[[:fabrice] Fabrice Desré]

Attachment: certerror.patch

Ok, I forgot to add the netError.css in jar.mn in the previous patch. This one reverts certerror pages to the old ones.

Comment 6

[Gregor Wagner [:gwagner]]

Comment on attachment 8347077 [details] [diff] [review]
certerror.patch

Review of attachment 8347077 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: b2g/chrome/content/netError.css
@@ +109,5 @@
> +  padding-left: 15px;
> +  background-image: url("chrome://browser/skin/images/arrowright-16.png");
> +  background-size: 11px 11px;
> +  background-repeat: no-repeat;
> +  background-position: left 0.3em;  

nit: whitespace

Comment 7

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/58bd8c6d2260

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/58bd8c6d2260

Comment 9

[Jason Smith [:jsmith]]

blocking+ for cert error regression from error refactoring

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6f050e02f802

Comment 11

[Jason Smith [:jsmith]]

Looks okay overall with a minor followup in bug 957838.