Closed Bug 949195 Opened 8 years ago Closed 8 years ago

Only call IsInRequest when JS_DEBUG.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: sstangl, Assigned: sstangl)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files)

Per Bug 939505 Comment 17, we still have a problem where IsInRequest is conditionally defined on JS_DEBUG, but then always used by MOZ_ASSERT, which is conditionally effectful on DEBUG. Gross!

Unfortunately, we can't just make IsInRequest conditional on DEBUG, since it's baked into the library based on the value of DEBUG at library compilation time.

This papers over the issue on m-c.
Attachment #8346192 - Flags: review?(efaustbmo)
Attached patch Patch for ESR24.Splinter Review
This papers over the issue on ESR24. Doesn't need to land -- standalone can carry separately.
Sean, this fixes the issue. Could you please get it merged soon?
Comment on attachment 8346192 [details] [diff] [review]
Only use IsInRequest when JS_DEBUG.

Review of attachment 8346192 [details] [diff] [review]:
-----------------------------------------------------------------

Gross. r=me
Attachment #8346192 - Flags: review?(efaustbmo) → review+
It's been merged into the standalone release (RC4).
What's the ETA on getting this merged on Moz central?
I'll merge it when I catch the next open tree.
https://hg.mozilla.org/mozilla-central/rev/3bf8e65bb2c1
Assignee: nobody → sstangl
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.