Only call IsInRequest when JS_DEBUG.

RESOLVED FIXED in mozilla29

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: sstangl, Assigned: sstangl)

Tracking

unspecified
mozilla29
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Created attachment 8346192 [details] [diff] [review]
Only use IsInRequest when JS_DEBUG.

Per Bug 939505 Comment 17, we still have a problem where IsInRequest is conditionally defined on JS_DEBUG, but then always used by MOZ_ASSERT, which is conditionally effectful on DEBUG. Gross!

Unfortunately, we can't just make IsInRequest conditional on DEBUG, since it's baked into the library based on the value of DEBUG at library compilation time.

This papers over the issue on m-c.
Attachment #8346192 - Flags: review?(efaustbmo)
(Assignee)

Comment 1

4 years ago
Created attachment 8346194 [details] [diff] [review]
Patch for ESR24.

This papers over the issue on ESR24. Doesn't need to land -- standalone can carry separately.

Comment 2

4 years ago
Sean, this fixes the issue. Could you please get it merged soon?

Comment 3

4 years ago
Comment on attachment 8346192 [details] [diff] [review]
Only use IsInRequest when JS_DEBUG.

Review of attachment 8346192 [details] [diff] [review]:
-----------------------------------------------------------------

Gross. r=me
Attachment #8346192 - Flags: review?(efaustbmo) → review+
(Assignee)

Comment 4

4 years ago
It's been merged into the standalone release (RC4).

Comment 5

4 years ago
What's the ETA on getting this merged on Moz central?
(Assignee)

Comment 6

4 years ago
I'll merge it when I catch the next open tree.
(Assignee)

Comment 7

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3bf8e65bb2c1
https://hg.mozilla.org/mozilla-central/rev/3bf8e65bb2c1
Assignee: nobody → sstangl
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.