949241 - enhance HAWK tests

Status: RESOLVED FIXED

(Cloud Services :: Server: Firefox Accounts, defect)

Description

[Brian Warner [:warner :bwarner]]

Attachment: hawk-test.diff

This patch adds an extra test for the HAWK code inside services/crypto/modules/utils.js . Unlike the rest of our code, HAWK uses a non-URL-safe base64 encoding for its payload ".hash" and HMAC output ".mac" fields. The test cases in the upstream (node.js) HAWK source code don't exercise the /+ characters in the payload hash, so this adds one that does.

This is aimed at mozilla-central.

Comment 1

[Richard Newman [:rnewman]]

Comment on attachment 8346246 [details] [diff] [review]
hawk-test.diff

Review of attachment 8346246 [details] [diff] [review]:
-----------------------------------------------------------------

Always nice to see test-only patches!

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/bc1774f6eece

Thanks for the patch, Brian! One request - in the future, please make sure you patches include the necessary commit information. Makes life much easier for those checking in on your behalf. Thanks! :)
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bc1774f6eece