Closed Bug 949292 Opened 6 years ago Closed 6 years ago

Stop exposing LoadStatus on the global object

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mccr8, Assigned: emk)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

No description provided.
I'm not sure what this is, but the interface, nsIDOMLoadStatus, looks simple enough.
We should rather just remove this crap from the global object.
Blocks: stdglobal
emk, do you think we should just morph this bug into removing this from the global?  I'm not sure what would actually involved with doing that so I'm not sure I'd be able to do it.
Is it insufficient to remove DOMCI?
I don't know anything about the pre-WebIDL setup.
See bug 916871 as an example of removing classinfo.
Assignee: continuation → VYV03354
Summary: Convert LoadStatus to WebIDL → Stop exposing LoadStatus on the global object
Comment on attachment 8347215 [details] [diff] [review]
Stop exposing LoadStatus on the global object

This seems ok, but can we just delete this IDL file?  Or make the interface noscript?  Or at least rename it to nsILoadStatus, without the DOM bit?
Attachment #8347215 - Flags: review?(bzbarsky) → review+
nsOfflineCacheUpdateItem and nsPrefetchNode implement this interface and nsOfflineCacheUpdateItem::GetStatus() is actually used. We will have to de-COM nsIDOMLoadStatus before removing. But indeed we can make it non-scriptable.

Waiting for the try result: https://tbpl.mozilla.org/?tree=Try&rev=fe01fde501e4
Blocks: 950311
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa1e7e58743c
Status: NEW → ASSIGNED
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/aa1e7e58743c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Added to the compat doc just in case. No other docs on MDN.
https://developer.mozilla.org/en-US/Firefox/Releases/29/Site_Compatibility
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.