Closed
Bug 949292
Opened 10 years ago
Closed 10 years ago
Stop exposing LoadStatus on the global object
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: mccr8, Assigned: emk)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
6.22 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•10 years ago
|
||
I'm not sure what this is, but the interface, nsIDOMLoadStatus, looks simple enough.
Assignee | ||
Comment 2•10 years ago
|
||
We should rather just remove this crap from the global object.
Blocks: stdglobal
Reporter | ||
Comment 3•10 years ago
|
||
emk, do you think we should just morph this bug into removing this from the global? I'm not sure what would actually involved with doing that so I'm not sure I'd be able to do it.
Assignee | ||
Comment 4•10 years ago
|
||
Is it insufficient to remove DOMCI?
Reporter | ||
Comment 5•10 years ago
|
||
I don't know anything about the pre-WebIDL setup.
Assignee | ||
Comment 6•10 years ago
|
||
See bug 916871 as an example of removing classinfo.
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8347215 -
Flags: review?(bzbarsky)
Reporter | ||
Updated•10 years ago
|
Assignee: continuation → VYV03354
Summary: Convert LoadStatus to WebIDL → Stop exposing LoadStatus on the global object
Comment 8•10 years ago
|
||
Comment on attachment 8347215 [details] [diff] [review] Stop exposing LoadStatus on the global object This seems ok, but can we just delete this IDL file? Or make the interface noscript? Or at least rename it to nsILoadStatus, without the DOM bit?
Attachment #8347215 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 9•10 years ago
|
||
nsOfflineCacheUpdateItem and nsPrefetchNode implement this interface and nsOfflineCacheUpdateItem::GetStatus() is actually used. We will have to de-COM nsIDOMLoadStatus before removing. But indeed we can make it non-scriptable. Waiting for the try result: https://tbpl.mozilla.org/?tree=Try&rev=fe01fde501e4
Assignee | ||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa1e7e58743c
Status: NEW → ASSIGNED
Flags: in-testsuite+
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/aa1e7e58743c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Comment 12•10 years ago
|
||
Added to the compat doc just in case. No other docs on MDN. https://developer.mozilla.org/en-US/Firefox/Releases/29/Site_Compatibility
Keywords: dev-doc-complete
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•