949308 - Hf builds need to output failures in a tbpl-recognizable way

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=31844293&tree=Mozilla-Inbound is a failing Hf log, and https://tbpl.mozilla.org/php/getParsedLog.php?id=31833744&tree=Mozilla-Inbound is a passing log.

Or maybe it's the other way around. Since both of them highlight nothing other than the false-positives from configure, it's hard to keep them straight.

Having the line about the failure match something in https://hg.mozilla.org/webtools/tbpl/file/default/php/inc/GeneralErrorFilter.php will make sheriffs (somewhat, if imperceptibly, closer to) happy; not matching anything will get your failures starred as "i;r" like whichever one of those two is the failing one was.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Add the magic cookie for signalling a failure

This looks vaguely right. My first attempt wasn't -- "TEST-UNEXPECTED-FAIL:..." doesn't look like it'd work.

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 8346627 [details] [diff] [review]
Add the magic cookie for signalling a failure

Looks reasonable to me. Dunno why the regex requires that trailing space, somebody must have been worried about matching TEST-UNEXPECTED-FAILURE-IS-NOT-AN-OPTION.

Comment 3

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/build/mozharness/rev/782d197660f1

Comment 4

[[e-mail] (:bhearsum)]

Merged to production.