Closed Bug 949355 Opened 12 years ago Closed 10 years ago

Intermittent devtools/styleeditor/test/browser_styleeditor_bug_740541_iframes.js | Test timed out

Categories

(DevTools :: Style Editor, defect)

Product:
DevTools
Component:
Style Editor
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox41 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: cbook, Assigned: sjakthol)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

bug-949355-iframe-loading.patch
6.10 KB, patch
sjakthol
: review+
Details | Diff | Splinter Review
Ubuntu ASAN VM 12.04 x64 fx-team opt test mochitest-browser-chrome on 2013-12-11 17:07:23 PST for push 9b247e7fc91f slave: tst-linux64-ec2-060 https://tbpl.mozilla.org/php/getParsedLog.php?id=31842952&tree=Fx-Team TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_bug_740541_iframes.js | Test timed out
Assignee: nobody → fayearthur
I am running into this issue on windows 8 when I run each subdirectory in a fresh instance of the browser: https://tbpl.mozilla.org/php/getParsedLog.php?id=33348454&tree=Try This is repeatable, not random. Any thoughts as to what I should hack to make this work would be appreciated.
Summary: Intermittent TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_bug_740541_iframes.js | Test timed out → Intermittent devtools/styleeditor/test/browser_styleeditor_bug_740541_iframes.js | Test timed out
(In reply to Joel Maher (:jmaher) from comment #16) > I am running into this issue on windows 8 when I run each subdirectory in a > fresh instance of the browser: > https://tbpl.mozilla.org/php/getParsedLog.php?id=33348454&tree=Try > > This is repeatable, not random. Any thoughts as to what I should hack to > make this work would be appreciated. Sorry for the late reply, Joel. I'm looking into this right now.
(In reply to Heather Arthur [:harth] from comment #82) > Sorry for the late reply, Joel. I'm looking into this right now. Any luck here? We're hitting this pretty frequently :)
Flags: needinfo?(fayearthur)
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #118) > (In reply to Heather Arthur [:harth] from comment #82) > > Sorry for the late reply, Joel. I'm looking into this right now. > > Any luck here? We're hitting this pretty frequently :) I know, sorry ): I think I know what the problem is, had trouble reproducing on try runs with logging though. I'll work on it this week.
Flags: needinfo?(fayearthur)
thanks :harth. I would be happy to help test or review any patches.
Disabled on OSX and Linux. https://hg.mozilla.org/integration/fx-team/rev/c615f6307f75
Whiteboard: [test disabled on Linux and OSX][leave open]
Heads up, I'm hoping that bug 971974 fixes this.
I think bug 971974 would have fixed this. What's the protocol?
Run a push through Try with it re-enabled, retrigger it a lot of times to make sure it doesn't fail intermittently, then ping here :)
Thanks Ryan. bug 971974 did not fix it sadly. It did fix the error, but now there's another error, a "Can't access a dead object" error.
Assignee: fayearthur → nobody
Attached patch bug-949355-iframe-loading.patch (obsolete) — — Splinter Review
Figured out what was causing this. The actor wasn't waiting for subframes to be loaded before it looked for their sheets causing some to be missing. This patch fixes the problem and re-enables the test. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ad0fe11e8f4
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Attachment #8613312 - Flags: review?(bgrinstead)
No longer blocks: t-w732-ix-002
Comment on attachment 8613312 [details] [diff] [review] bug-949355-iframe-loading.patch Review of attachment 8613312 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Nit: there's a typo in the commit message - 'doind'
Attachment #8613312 - Flags: review?(bgrinstead) → review+
Fixed the typo in the commit message.
Attachment #8613312 - Attachment is obsolete: true
Attachment #8615010 - Flags: review+
Keywords: intermittent-failure → checkin-needed
Whiteboard: [test disabled on Linux and OSX][leave open] → [test disabled on Linux and OSX]
https://hg.mozilla.org/mozilla-central/rev/aebbbe2efe1d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Whiteboard: [test disabled on Linux and OSX]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: