949360 - Check for Image AllocateBuffer() failures

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Chris Peterson [:cpeterson]]

This patch began as a fix for a warning that local variable `status` was unused in release builds:

gfx/layers/ipc/SharedPlanarYCbCrImage.cpp:133:8 [-Wunused-variable] unused variable 'status'

But then I saw that a couple Image functions did not check whether AllocateBuffer() returned null. This patch checks for AllocateBuffer() returning null and also avoids setting mBufferSize to a non-zero size when mBuffer is null.

Green try run:
https://tbpl.mozilla.org/?tree=Try&rev=1598ed0935bc

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: handle-AllocateBuffer-failure.patch

Comment 3

[Nicolas Silva [:nical]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d9cf51a012a

Comment 4

[(no longer active)]

Backed out because of mochitest-3 timeouts:

http://hg.mozilla.org/integration/mozilla-inbound/rev/7631ae46b853
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=6d9cf51a012a

Note that the WinXP mochitest-3 crashes were probably caused by bug 948777.

Comment 5

[(no longer active)]

And your name is cleared!  Relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/6f419c7c2873

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6f419c7c2873

Comment 7

[Chris Peterson [:cpeterson]]

Comment on attachment 8346423 [details] [diff] [review]
handle-AllocateBuffer-failure.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Not a regression, just some omitted error checks
User impact if declined: No big problems. These error checks have been missing for a couple releases without causing any major problems.
Testing completed (on m-c, etc.): m-c for one week
Risk to taking this patch (and alternatives if risky): Low risk. It just adds a couple error checks for failed allocations of graphics buffer allocation.
String or IDL/UUID changes made by this patch: None

Comment 8

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/274f1e06b821