949380 - Talos regressions caused by UITour push 166d27bf3b4b

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Matthew N. [:MattN]]

I suspect this is caused by my removal of @hidden=true in http://hg.mozilla.org/integration/fx-team/diff/8c0d1c91905c/browser/base/content/browser.xul

Tree management thread: https://groups.google.com/forum/#!topic/mozilla.dev.tree-management/6_MzcmcU7zE

Blamed pushlog: http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=3cafeb339fac&tochange=166d27bf3b4b

Comment 1

[Matthew N. [:MattN]]

I don't have time to wait for a try push and test my theory as it's 2 AM. I'm going to leave it until morning since this is Ubuntu only and it's not clear whether it's the UITour bugs or bug 897074 which needs to be backed out (see http://mzl.la/1grqGDU ).

Comment 2

[Matthew N. [:MattN]]

Attachment: v.1 Add @hidden=true initially to UITour panels

I haven't measured the performance yet as my linux build is still going and I just pushed to Try now but I'm think there's a greater than 50% chance this is the cause and I'd like to get this landed ASAP if it is.

Comment 3

[Matthew N. [:MattN]]

Oops, the try push is https://tbpl.mozilla.org/?tree=Try&showall=1&rev=cfc79f412b15 and I will compare it to (1bc33fa19b24) to see an improvement:

  http://compare-talos.mattn.ca/?oldRevs=1bc33fa19b24&newRev=cfc79f412b15&submit=true

and to the previous m-c base (76551fba7121) to show no regression: 

  http://compare-talos.mattn.ca/?oldRevs=76551fba7121&newRev=cfc79f412b15&submit=true

Comment 4

[Matthew N. [:MattN]]

Attachment: Try-Non-PGO Ubuntu 32 TART graph for cfc79f412b15

(In reply to Matthew N. [:MattN] from comment #3)
> and to the previous m-c base (76551fba7121) to show no regression: 
> 
> http://compare-talos.mattn.ca/?oldRevs=76551fba7121&newRev=cfc79f412b15&submit=true

Results look good. The 10% remaining regression on Ubuntu 32 TART is just noise (from looking at the graph).

Comment 5

[Matthew N. [:MattN]]

Attachment: v.1 Add @hidden=true initially to UITour panels

Oops, incomplete attachment.

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/integration/fx-team/rev/b6dab3694be2

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b6dab3694be2