Closed Bug 949392 Opened 6 years ago Closed 6 years ago

[e.me] 'Music2' removed from 'Music' collection when adding a web app

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

x86
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed)

RESOLVED FIXED
blocking-b2g 1.3+
Tracking Status
b2g-v1.3 --- fixed

People

(Reporter: amirn, Assigned: amirn)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
ranbena
: review+
Details | Review
STR:

1. make reset-gaia
2. open the Music collection
3. wait until Music2 is added to the collection (this is done by a background process that runs on the first E.me load, populating the collections with apps installed on device)
4. wait for the web results to load and long-tap on one
5. tap 'add to top of collection'

observed:
the web result is added but 'Music2' is removed from the collection

expected:
'Music2' is not removed from the collection
Assignee: nobody → amirn
Attached file Redirect to PR
Attachment #8346468 - Flags: review?(ran)
Comment on attachment 8346468 [details] [review]
Redirect to PR

Good work
Attachment #8346468 - Flags: review?(ran) → review+
landed: https://github.com/mozilla-b2g/gaia/commit/60fdc90
Status: NEW → RESOLVED
blocking-b2g: --- → 1.3?
Closed: 6 years ago
Resolution: --- → FIXED
Music2 isn't an app that will show up in production builds, which makes this a non-blocker.
blocking-b2g: 1.3? → -
Music2 is only an example. The bug will likely happen for other pre-installed apps.

I think it should be a blocker.
Flags: needinfo?(jsmith)
Can you include actual end-user STR that would happen with a production app?
Flags: needinfo?(jsmith)
It depends on the build's installed apps/collections configuration.

To reproduce 2 things must apply:
1. an installed app is matched to a Collection (Music is matched with the Music collection, SMS with the Social collection etc.)
2. the matching Collection is not pre-defined with this app in it's manifest file (see for example: https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/collections/music/manifest.collection)

When Collections are initialized for the first time we scan the apps installed on the device for matches that are not listed on the collection's manifest, and update it.

For example, if some carrier's production build includes Facebook's app the bug will reproduce with the Social collection.

Hope that was clear enough.
Okay - thanks for clarification. Sounds like this is a blocker then.
blocking-b2g: - → 1.3+
Uplifted 60fdc90f3463f5327d889c7caa2b5f1c8bf0abf2 to:
v1.3: 3e119473af260e7de80e647932ad8cda60c32147
You need to log in before you can comment on or make changes to this bug.