949392 - [e.me] 'Music2' removed from 'Music' collection when adding a web app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Amir Nissim (:amirn)]

STR:

1. make reset-gaia
2. open the Music collection
3. wait until Music2 is added to the collection (this is done by a background process that runs on the first E.me load, populating the collections with apps installed on device)
4. wait for the web results to load and long-tap on one
5. tap 'add to top of collection'

observed:
the web result is added but 'Music2' is removed from the collection

expected:
'Music2' is not removed from the collection

Comment 1

[Amir Nissim (:amirn)]

Attachment: Redirect to PR

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 8346468 [details] [review]
Redirect to PR

Good work

Comment 3

[Amir Nissim (:amirn)]

landed: https://github.com/mozilla-b2g/gaia/commit/60fdc90

Comment 4

[Jason Smith [:jsmith]]

Music2 isn't an app that will show up in production builds, which makes this a non-blocker.

Comment 5

[Amir Nissim (:amirn)]

Music2 is only an example. The bug will likely happen for other pre-installed apps.

I think it should be a blocker.

Comment 6

[Jason Smith [:jsmith]]

Can you include actual end-user STR that would happen with a production app?

Comment 7

[Amir Nissim (:amirn)]

It depends on the build's installed apps/collections configuration.

To reproduce 2 things must apply:
1. an installed app is matched to a Collection (Music is matched with the Music collection, SMS with the Social collection etc.)
2. the matching Collection is not pre-defined with this app in it's manifest file (see for example: https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/collections/music/manifest.collection)

When Collections are initialized for the first time we scan the apps installed on the device for matches that are not listed on the collection's manifest, and update it.

For example, if some carrier's production build includes Facebook's app the bug will reproduce with the Social collection.

Hope that was clear enough.

Comment 8

[Jason Smith [:jsmith]]

Okay - thanks for clarification. Sounds like this is a blocker then.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 60fdc90f3463f5327d889c7caa2b5f1c8bf0abf2 to:
v1.3: 3e119473af260e7de80e647932ad8cda60c32147