Closed Bug 949401 Opened 6 years ago Closed 6 years ago

Marionette python client is missing resources from latest marionette_client 0.7.0

Categories

(Testing :: Marionette, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox27 wontfix, firefox28 fixed, firefox29 fixed, b2g-v1.3 fixed)

RESOLVED FIXED
mozilla29
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
b2g-v1.3 --- fixed

People

(Reporter: Bebe, Assigned: davehunt)

References

Details

Attachments

(1 file)

The latest marionette client is missing some resources files

When we run tests we get:
test_clock_delete_alarm (test_clock_delete_alarm.TestClockDeleteAlarm)
Delete alarm ... ok

----------------------------------------------------------------------
Ran 1 test in 57.028s

OK

SUMMARY
-------
passed: 1
failed: 0
todo: 0
Traceback (most recent call last):
  File "/home/florinstrugariu/.virtualenvs/gaia/bin/gaiatest", line 9, in <module>
    load_entry_point('gaiatest==0.21', 'console_scripts', 'gaiatest')()
  File "/home/florinstrugariu/gaia/gaia/tests/python/gaia-ui-tests/gaiatest/runtests.py", line 49, in main
    cli(runner_class=GaiaTestRunner, parser_class=GaiaTestOptions)
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.0-py2.7.egg/marionette/runtests.py", line 28, in cli
    runner = startTestRunner(runner_class, options, tests)
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.0-py2.7.egg/marionette/runtests.py", line 19, in startTestRunner
    runner.run_tests(tests)
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.0-py2.7.egg/marionette/runner/base.py", line 748, in run_tests
    run_tests(tests)
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.0-py2.7.egg/marionette/runner/mixins/reporting.py", line 41, in html_run_tests
    f.write(self.generate_html(self.results))
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.0-py2.7.egg/marionette/runner/mixins/reporting.py", line 130, in generate_html
    __name__, os.path.sep.join(['resources', 'htmlreport', 'style.css']))),
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/pkg_resources.py", line 957, in resource_string
    self, resource_name
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/pkg_resources.py", line 1409, in get_resource_string
    return self._get(self._fn(self.module_path, resource_name))
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/pkg_resources.py", line 1536, in _get
    stream = open(path, 'rb')
IOError: [Errno 2] No such file or directory: '/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.0-py2.7.egg/marionette/runner/mixins/resources/htmlreport/style.css'


I think we haven't included the resources folder in the python package

http://hg.mozilla.org/mozilla-central/file/1ad9af3a2ab8/testing/marionette/client/setup.py#l31

http://hg.mozilla.org/mozilla-central/file/1ad9af3a2ab8/testing/marionette/client/marionette/runner/mixins/resources
Blocks: 949405
Assignee: nobody → dave.hunt
No longer blocks: 949405
Status: NEW → ASSIGNED
Blocks: 949405
Summary: Marionette python client is missing resources form latest marionette_client 0.7.0 → Marionette python client is missing resources from latest marionette_client 0.7.0
Blocks: 949406
No longer blocks: 949405
Comment on attachment 8346485 [details] [diff] [review]
Add resources to MANIFEST.in file. v1.0

Review of attachment 8346485 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the fix!
Attachment #8346485 - Flags: review?(mdas) → review+
https://hg.mozilla.org/mozilla-central/rev/7bd725c5371b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Looks like this slipped through the cracks and is likely the reason Gu went red on Aurora after bug 949954 went live.

https://hg.mozilla.org/releases/mozilla-aurora/rev/2b2a0d087da7
You need to log in before you can comment on or make changes to this bug.