949401 - Marionette python client is missing resources from latest marionette_client 0.7.0

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Florin Strugariu [:Bebe]]

The latest marionette client is missing some resources files

When we run tests we get:
test_clock_delete_alarm (test_clock_delete_alarm.TestClockDeleteAlarm)
Delete alarm ... ok

----------------------------------------------------------------------
Ran 1 test in 57.028s

OK

SUMMARY
-------
passed: 1
failed: 0
todo: 0
Traceback (most recent call last):
  File "/home/florinstrugariu/.virtualenvs/gaia/bin/gaiatest", line 9, in <module>
    load_entry_point('gaiatest==0.21', 'console_scripts', 'gaiatest')()
  File "/home/florinstrugariu/gaia/gaia/tests/python/gaia-ui-tests/gaiatest/runtests.py", line 49, in main
    cli(runner_class=GaiaTestRunner, parser_class=GaiaTestOptions)
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.0-py2.7.egg/marionette/runtests.py", line 28, in cli
    runner = startTestRunner(runner_class, options, tests)
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.0-py2.7.egg/marionette/runtests.py", line 19, in startTestRunner
    runner.run_tests(tests)
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.0-py2.7.egg/marionette/runner/base.py", line 748, in run_tests
    run_tests(tests)
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.0-py2.7.egg/marionette/runner/mixins/reporting.py", line 41, in html_run_tests
    f.write(self.generate_html(self.results))
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.0-py2.7.egg/marionette/runner/mixins/reporting.py", line 130, in generate_html
    __name__, os.path.sep.join(['resources', 'htmlreport', 'style.css']))),
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/pkg_resources.py", line 957, in resource_string
    self, resource_name
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/pkg_resources.py", line 1409, in get_resource_string
    return self._get(self._fn(self.module_path, resource_name))
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/pkg_resources.py", line 1536, in _get
    stream = open(path, 'rb')
IOError: [Errno 2] No such file or directory: '/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.0-py2.7.egg/marionette/runner/mixins/resources/htmlreport/style.css'


I think we haven't included the resources folder in the python package

http://hg.mozilla.org/mozilla-central/file/1ad9af3a2ab8/testing/marionette/client/setup.py#l31

http://hg.mozilla.org/mozilla-central/file/1ad9af3a2ab8/testing/marionette/client/marionette/runner/mixins/resources

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Add resources to MANIFEST.in file. v1.0

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8346485 [details] [diff] [review]
Add resources to MANIFEST.in file. v1.0

Review of attachment 8346485 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the fix!

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

landed in m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7bd725c5371b

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7bd725c5371b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Looks like this slipped through the cracks and is likely the reason Gu went red on Aurora after bug 949954 went live.

https://hg.mozilla.org/releases/mozilla-aurora/rev/2b2a0d087da7