94944 - [Buttons] Allow button to really behave like a box and allow child content

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[David Hyatt]

The main issue here is going to be patching the bindings and then
patching XBL to enable default content support inherits.

Comment 1

[David Hyatt]

Attachment: Patch that fixes a number of XBL issues and redoes the button bindings in modern and classic

Comment 2

[David Hyatt]

Looking for r/sr from hewitt and waterson.

If you want to see some of the layout issues this patch is fixing, just go 
look at the mess the current trunk makes of:

http://www.mozilla.org/projects/xul/tests/buttons.xul

Comment 3

[Joe Hewitt (gone)]

Since you are adding a box to the top of the content in the modern button
binding, you will also have to update the CSS for selectors like this:

button:hover:active > .button-box-left > .button-left-top

so that they look like this:

button:hover:active > .box-inherit > .button-box-left > .button-left-top,

Comment 4

[David Hyatt]

Attachment: Patch #2 for the modern theme, fixing the style rules.

Comment 5

[Joe Hewitt (gone)]

r=hewitt

Comment 6

[Dan M]

r=danm too

Comment 7

[David Hyatt]

Fixed.

Comment 8

[[e-mail]]

What are the new effects of text-align?