Recent changes to gaiatest atoms cause JavascriptException: TypeError: window.wrappedJSObject.WindowManager when running across branches

RESOLVED FIXED

Status

Firefox OS
Gaia::System::Window Mgmt
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Packages like b2gperf depend on gaiatest, which includes the JavaScript atoms. These have recently been updated for the AppWindowManager changes, but this means that the distributed version of gaiatest is now only compatible with the master branch.

As we run these tests against multiple branches, we should add backwards compatibility to the atoms at least until branches are no longer supported.
(Assignee)

Comment 1

5 years ago
Created attachment 8346552 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14613

Pointer to Github pull-request
(Assignee)

Comment 2

5 years ago
Comment on attachment 8346552 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14613

This fixes it for me. Mind giving a review, Alive?
Attachment #8346552 - Flags: review?(alive)
Comment on attachment 8346552 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14613

If this works for you I definitely should give r+
Attachment #8346552 - Flags: review?(alive) → review+
(Assignee)

Comment 4

5 years ago
Landed in:
https://github.com/mozilla-b2g/gaia/commit/d9dd00fa4b67c6965fd0787301225edf6b1ec120 (master)
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
No longer depends on: 907013
See Also: → bug 907013
You need to log in before you can comment on or make changes to this bug.