949467 - Fix intermittent fail in test_homescreen_delete_app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Viorela Ioia [:viorela]]

This test fails with the following error:
Traceback (most recent call last):
  File "/home/viorelaioia/.virtualenvs/gaia_new/local/lib/python2.7/site-packages/marionette_client-0.7.0-py2.7.egg/marionette/marionette_test.py", line 143, in run
    testMethod()
  File "/home/viorelaioia/WebQA/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/test_homescreen_delete_app.py", line 41, in test_delete_app
    self.wait_for_element_displayed(*self._notification_banner_locator)
  File "/home/viorelaioia/WebQA/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 995, in wait_for_element_displayed
    raise TimeoutException('Element %s present but not displayed before timeout' % locator)
TEST-UNEXPECTED-FAIL | test_homescreen_delete_app.py test_homescreen_delete_app.TestDeleteApp.test_delete_app | TimeoutException: Element system-banner present but not displayed before timeout

Comment 1

[Askeing Yen[:askeing][:fyen]]

https://github.com/mozilla-b2g/gaia/commit/ab0b63e94048223c96a2d0e9f4f189a75b437922
=> failed.

https://github.com/mozilla-b2g/gaia/commit/bef0c2fec1726eec61284241b24f0e93efc25840
=> passed.

seems like we do not need to modify the gaiatest.

Comment 2

[[:AndreiH]]

I see that sometimes after the app is installed the notification appears or it doesn't

Comment 3

[Zac C (:zac)]

Can someone remove the wait for the notification entirely and just wait for the icon to be present?

We could be being 'tricked' by some other kind of notification.

Comment 4

[[:AndreiH]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/14846

Maybe we are 'tricked' by '1 update is available' notification that appears in the top of the screen

Comment 5

[Viorela Ioia [:viorela]]

Comment on attachment 8350026 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/14846

See comment in the PR

Comment 6

[Zac C (:zac)]

Comment on attachment 8350026 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/14846

r+

Comment 7

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/ba2cd3f149cb2e39b8d0449b4e862b036884a248

Comment 8

[Viorela Ioia [:viorela]]

Attachment: PR for v1.3: https://github.com/mozilla-b2g/gaia/pull/15205

Comment 9

[Florin Strugariu [:Bebe]]

merged in https://github.com/mozilla-b2g/gaia/commit/1f029aa4c924d6c59fd7e8c6d9786a7370755d49