Closed
Bug 949474
Opened 11 years ago
Closed 11 years ago
Reflect the spec change for the nominal range of the sampleRate argument of the AudioContext.createBuffer
Categories
(Core :: Web Audio, defect, P3)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: padenot, Assigned: padenot)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Change the DOM bits (nominal range and exception), change the tests, add a test
to make sure we can create a buffer with 32 channels (required by the spec).
Also, forbid the creation of a zero channel buffer (This was decided some time
ago in the wg, but somehow I did not write the gecko patch).
Attachment #8346565 -
Flags: review?(ehsan)
Assignee | ||
Comment 2•11 years ago
|
||
(spec patch: https://github.com/padenot/web-audio-api/commit/efcd0e0d070131f56fc73678db22f8ccbd14eae1, pushed on my branch since it's going to be merged soon and I did not want to write the patch twice).
Updated•11 years ago
|
Priority: -- → P3
Updated•11 years ago
|
Attachment #8346565 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Backed out for test_bug808374.html failures on most platforms.
https://hg.mozilla.org/integration/mozilla-inbound/rev/6532132dc01e
https://tbpl.mozilla.org/php/getParsedLog.php?id=31889128&tree=Mozilla-Inbound
Assignee | ||
Comment 5•11 years ago
|
||
Relanded with the obvious fix: https://hg.mozilla.org/integration/mozilla-inbound/rev/6bc4294d2c85
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•