949487 - Harden the AppWindowManager against app that gets insta-killed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Etienne Segonzac (:etienne)]

Found this one thanks to nuwa :)

I was getting and |appterminated| between the moment we send the |appcreated| and the moment in |AppWindowManager._updateActiveApp()|.

I know, crazy.
But still worth checking that the app |isRunning()| otherwise we end up with a bad |displayedApp".

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

OOPS I didn't read the description...
So you know what happens.

So let's try to check the nextApp in switchApp is running or not. If not, just skip the switch!

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Maybe:

AppWindow.prototype.isDead() = function() {
  return this._killed;
};

I also love if we have AppWindow.isAlive()  ;)

Comment 4

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

I was tempted to go the |isAlive| route, but for our case here |isDead| is way more expressive :)

I was able to confirm that this patch fixes the issue by reflashing a broken gecko on my device.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8347346 [details] [review]
Gaia PR

r+ and look forward to the day we actually need isActive() comes.

Comment 6

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/75a30a73412146f9759a238ed8ae90bc8d3b18a9