949590 - When switching browsers, wait for the previous instance to close the profile before launching

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect, P2)

Description

[Jim Mathies [:jimm]]

particularly on debug builds, we can end up with both browsers trying to access the default profile. This will cause the spawned browser to crash.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch v.1

This makes things more reliable. Also, this fixes a pretty bad bug, when we shutdown in nsAppRunner to flip to metro we were actually always trying to launch the desktop browser as well.

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8347260 [details] [diff] [review]
patch v.1

Review of attachment 8347260 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/shell/commandexecutehandler/CEHHelper.h
@@ +14,5 @@
>  #include <d3d10misc.h>
>  #include <atlbase.h>
>  #include <shlobj.h>
>  
> +#define SHOW_CONSOLE 1

removed in my local patch

Comment 3

[Brian R. Bondy [:bbondy]]

Comment on attachment 8347260 [details] [diff] [review]
patch v.1

Review of attachment 8347260 [details] [diff] [review]:
-----------------------------------------------------------------

great :)

Comment 4

[Marco Mucci [:MarcoM]]

Hey Jim, can you provide a point value and I'll add it to IT#21.

Comment 5

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/fx-team/rev/7ad2f3b9823b

Comment 6

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/fx-team/rev/507e9a3471b8

follow up to remove that darn console line. forgot to do an hg qdiff on the patch file.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7ad2f3b9823b
https://hg.mozilla.org/mozilla-central/rev/507e9a3471b8
https://hg.mozilla.org/mozilla-central/rev/79e6ae7e76f8

Comment 8

[Jim Mathies [:jimm]]

Comment on attachment 8347260 [details] [diff] [review]
patch v.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Fixes a long standing issue.
User impact if declined: Wonky browser startup.
Testing completed (on m-c, etc.): yes.
Risk to taking this patch (and alternatives if risky): Minimal. 
String or IDL/UUID changes made by this patch: None.

Comment 9

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ce40b652eaef (includes the bustage fixes)

Comment 10

[Cornel Ionce [:noni] [Hubs QA]]

Verified as fixed on latest nightly (build ID: 20140112030204) and latest aurora (build ID: 20140112004002).