Closed Bug 949612 Opened 11 years ago Closed 11 years ago

Restore closed tabs and make the JSON sessionstore format for them compatible with desktop

Categories

(Firefox for Metro Graveyard :: General, defect, P2)

Product:
Firefox for Metro Graveyard
Component:
General
Platform:
x86_64
Windows 8
Type:
defect

Tracking

(firefox28 verified, firefox29 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 28
Tracking Flags:
Tracking Status
firefox28 --- verified
firefox29 --- verified

People

(Reporter: emtwo, Assigned: emtwo)

References

Details

(Whiteboard: [beta28] p=3)

Attachments

(1 file)

v1: Restore closed tabs data on startup and adjust json format to match desktop
6.99 KB, patch
mbrubeck
: review+
mbrubeck
: feedback+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Spawned from bug 924886 comment 11, point 2. Our closed tabs on Metro are currently not restorable when you close and re-open the browser. Also, the JSON format for the way they are saved in sessionstore.js is slightly different from desktop.
With this patch, after closing a tab in desktop or metro and switching to the other mode, you can re-open the tab with ctrl+shift+t
Attachment #8346723 - Flags: feedback?(mbrubeck)
Blocks: 924886
Whiteboard: p=3
Assignee: nobody → msamuel
Blocks: metrov1it21
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: p=3 → [beta28] p=3
Attachment #8346723 - Flags: feedback?(mbrubeck) → feedback+
Attachment #8346723 - Flags: review?(mbrubeck)
Attachment #8346723 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/integration/fx-team/rev/49d860258f52
Whiteboard: [beta28] p=3 → [fixed-in-fx-team][beta28] p=3
https://hg.mozilla.org/mozilla-central/rev/49d860258f52
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][beta28] p=3 → [beta28] p=3
Target Milestone: --- → Firefox 29
Comment on attachment 8346723 [details] [diff] [review] v1: Restore closed tabs data on startup and adjust json format to match desktop [Approval Request Comment] Bug caused by (feature/regressing bug #): Part of bug 924860 User impact if declined: Users in Metro will not be able to restore closed tabs. Users in desktop will not be able to restore tabs closed in metro after switching to desktop Testing completed (on m-c, etc.): Tested that the changes work on mc Risk to taking this patch (and alternatives if risky): low risk, only Metro code is affected String or IDL/UUID changes made by this patch: none
Attachment #8346723 - Flags: approval-mozilla-aurora?
Attachment #8346723 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Target Milestone: Firefox 29 → Firefox 28
Flags: in-qa-testsuite?
Keywords: verifyme
Verified as fixed with both latest Aurora 28.0a2 (build ID: 20131223004002) and latest Nightly 29.0a1 (build ID: 20131223030203) on Win 8 64-bit: I'm able to restore tabs closed in Metro after switching to Desktop and viceversa using Ctrl+Shift+T shortcut.
Status: RESOLVED → VERIFIED
status-firefox28: fixed → verified
status-firefox29: fixed → verified
Keywords: verifyme
Setting in-qa-testsuite- since we don't support Metro anymore
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: