949629 - Button play should reload the runtime app

Status: VERIFIED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Alexandre Poirot [:ochameau]]

As we can't open an app toolbox/debugger before the app is started,
it is currently really hard (impossible?) to debug app startup code.
You have to work around that by delaying initialization code in order to open a toolbox, set the break point before the code runs.

It's not really clear how we can address that, but that sounds like a quite common usage!

Comment 1

[Myk Melez [:myk] [@mykmelez]]

I think I've been able to do this in the past by opening a toolbox and then updating the app.

Comment 3

[Paul Rouget [:paul]]

So this now works for imported apps, but not for runtime apps.
The play button should be activated and do a reload.

Comment 4

[Girish Sharma [:Optimizer]]

Maybe change the icon to a reload icon as well ?

Comment 6

[Paul Rouget [:paul]]

This has been asked a few times by gaia hackers and some people in the B2G perf team. They want to add breakpoints to startup code. Not sure if we want to introduce a new button, or use the play button with a different image.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Reload runtime apps on play

Can't we just make the play button reload runtime apps...?  I mean, we can get a new icon later if we want, but let's just make it work at least.

This seems to work for me, but the comments here make me feel like I am missing something. :)

Try: https://tbpl.mozilla.org/?tree=Try&rev=8f844ba99ec2

Comment 8

[Paul Rouget [:paul]]

(In reply to J. Ryan Stinnett [:jryans] from comment #7)
> Created attachment 8477588 [details] [diff] [review]
> Reload runtime apps on play
> 
> Can't we just make the play button reload runtime apps...?  I mean, we can
> get a new icon later if we want, but let's just make it work at least.

Yep. Let's get a reload button: bug 1057958

> This seems to work for me, but the comments here make me feel like I am
> missing something. :)

Nope. That's it.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/76cddd08ee7e

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/76cddd08ee7e

Comment 12

[Petruta Horea [:phorea], Desktop QA]

Verified that apps are reloaded when play button is selected on simulators and a Flame device with 1.4.
Used Aurora 34.0a2 2014-10-08 under Win 7 64-bit, Ubuntu 13.04 64-bit and Mac OSX 10.9.5.