Closed
Bug 949643
Opened 11 years ago
Closed 11 years ago
[WebVTT] Implement VTTCue::PositionAlign
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: reyre, Assigned: reyre)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file, 1 obsolete file)
|
4.77 KB,
patch
|
Details | Diff | Splinter Review |
This is a new property on the VTTCue idl.
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Comment 1•11 years ago
|
||
I've have similar concerns for this bug as bug 949642. We could have a different align enum for both positionAlign and lineAlign and have the WebIDL bindings do the work for us.
Attachment #8347342 -
Flags: review?(giles)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8347342 [details] [diff] [review]
Vug 949643 - Implement VTTCue::PositionAlign r=rillian
Review of attachment 8347342 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry this took so long.
Attachment #8347342 -
Flags: review?(giles) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Rebasing to current. Carrying forward r=rillian.
Try looks green: https://tbpl.mozilla.org/?tree=Try&rev=61a9024921ff
Attachment #8347342 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Flags: in-testsuite+
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•