[WebVTT] Implement VTTCue::PositionAlign

RESOLVED FIXED in mozilla29

Status

()

Core
Audio/Video
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: reyre, Assigned: reyre)

Tracking

(Blocks: 1 bug)

Trunk
mozilla29
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
This is a new property on the VTTCue idl.
(Assignee)

Updated

4 years ago
Assignee: nobody → rick.eyre
Blocks: 629350
(Assignee)

Comment 1

4 years ago
Created attachment 8347342 [details] [diff] [review]
Vug 949643 - Implement VTTCue::PositionAlign r=rillian

I've have similar concerns for this bug as bug 949642. We could have a different align enum for both positionAlign and lineAlign and have the WebIDL bindings do the work for us.
Attachment #8347342 - Flags: review?(giles)
Comment on attachment 8347342 [details] [diff] [review]
Vug 949643 - Implement VTTCue::PositionAlign r=rillian

Review of attachment 8347342 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry this took so long.
Attachment #8347342 - Flags: review?(giles) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 8358008 [details] [diff] [review]
v2: Implement VTTCue::PositionAlign r=rillian

Rebasing to current. Carrying forward r=rillian.

Try looks green: https://tbpl.mozilla.org/?tree=Try&rev=61a9024921ff
Attachment #8347342 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a01d64b4d985
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.