Closed Bug 949643 Opened 7 years ago Closed 7 years ago

[WebVTT] Implement VTTCue::PositionAlign

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: reyre, Assigned: reyre)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 1 obsolete file)

This is a new property on the VTTCue idl.
Assignee: nobody → rick.eyre
Blocks: webvtt
I've have similar concerns for this bug as bug 949642. We could have a different align enum for both positionAlign and lineAlign and have the WebIDL bindings do the work for us.
Attachment #8347342 - Flags: review?(giles)
Comment on attachment 8347342 [details] [diff] [review]
Vug 949643 - Implement VTTCue::PositionAlign r=rillian

Review of attachment 8347342 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry this took so long.
Attachment #8347342 - Flags: review?(giles) → review+
Rebasing to current. Carrying forward r=rillian.

Try looks green: https://tbpl.mozilla.org/?tree=Try&rev=61a9024921ff
Attachment #8347342 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a01d64b4d985
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.