Closed Bug 949680 Opened 6 years ago Closed 6 years ago

Optimize null input in WaveShaperNode

Categories

(Core :: Web Audio, defect, P1)

x86_64
Linux
defect

Tracking

()

RESOLVED INVALID

People

(Reporter: karlt, Assigned: karlt)

Details

(Keywords: perf)

Performance of Web Audio graph is heavily dependent on skipping processing of silence because processing in unreferenced nodes continues until they are garbage collected.

Nodes should produce a null chunk when they know the output is silent.  If not, the rest of the graph downstream will need to process the chunk.

For WaveShaperNode, that can be when the center value of the curve array is zero and the input is null, though resampler latency should be considered.
Keywords: perf
There is already a test on aInput.mChannelData.Length(), which causes bug 961932.
No longer blocks: 865251
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.