949682 - Add the ability to freeze sequence attribute return values

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Jonas tells me if we do this he might use it.  ;)

We can also use it for Gamepad.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Add a [Frozen] annotation on WebIDL attributes that have sequence types.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Make gamepad use frozen sequences.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8346839 [details] [diff] [review]
part 2.  Make gamepad use frozen sequences.

Review of attachment 8346839 [details] [diff] [review]:
-----------------------------------------------------------------

This seems sensible. Is there a way to indicate that this is the desired behavior in the spec?

Comment 4

[Boris Zbarsky [:bzbarsky]]

We're not sure how to go about speccing this yet, actually.  We're not even sure how to spec the [Cached] behavior.  https://www.w3.org/Bugs/Public/show_bug.cgi?id=23682 is open on the spec angle of this.

I should probably sit down with Cameron and talk over how to express all this stuff in WebIDL.

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 8346837 [details] [diff] [review]
part 1.  Add a [Frozen] annotation on WebIDL attributes that have sequence types.

Review of attachment 8346837 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +5174,5 @@
> +                                              "args.rval().isObject()")
> +                freezeValue = freezeValue.define() + "\n"
> +            else:
> +                freezeValue = ""
> +                

Trailing whitespace.

::: dom/bindings/test/TestCodeGen.webidl
@@ +305,5 @@
>    readonly attribute sequence<Dict>? readonlyNullableSequenceOfDictionaries;
> +  [Cached, Pure, Frozen]
> +  readonly attribute sequence<Dict> readonlyFrozenSequence;
> +  [Cached, Pure, Frozen]
> +  readonly attribute sequence<Dict>? readonlyFrozenNullableSequence;  

Trailing whitespace.

::: dom/bindings/test/TestExampleGen.webidl
@@ +201,5 @@
>    readonly attribute sequence<Dict>? readonlyNullableSequenceOfDictionaries;
> +  [Cached, Pure, Frozen]
> +  readonly attribute sequence<long> readonlyFrozenSequence;
> +  [Cached, Pure, Frozen]
> +  readonly attribute sequence<long>? readonlyFrozenNullableSequence;  

Trailing whitespace.

::: dom/bindings/test/TestJSImplGen.webidl
@@ +222,5 @@
>    readonly attribute sequence<Dict>? readonlyNullableSequenceOfDictionaries;
> +  [Cached, Pure, Frozen]
> +  readonly attribute sequence<long> readonlyFrozenSequence;
> +  [Cached, Pure, Frozen]
> +  readonly attribute sequence<long>? readonlyFrozenNullableSequence;  

Trailing whitespace.

Comment 6

[Boris Zbarsky [:bzbarsky]]

With the whitespace nits fixed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/40dd59af8938
https://hg.mozilla.org/integration/mozilla-inbound/rev/fba171682148

Comment 7

[Boris Zbarsky [:bzbarsky]]

https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#Frozen

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/40dd59af8938
https://hg.mozilla.org/mozilla-central/rev/fba171682148