Closed
Bug 949742
Opened 12 years ago
Closed 12 years ago
OdinMonkey: 20% regression of Skinning after Float32 Odin landing
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: bbouvier, Assigned: dougc)
References
Details
Attachments
(1 file)
|
1006 bytes,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
According to AWFY, it's present on both x64 and x86. I also get some regression when running it locally on my machine. Needs some investigation.
|
Assignee | |
Comment 1•12 years ago
|
||
One difference noted is that Float32ToDouble was not allowing the source and destination to use the same register. This seems to account for much of the performance difference here.
Attachment #8347025 -
Flags: review?(benj)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 8347025 [details] [diff] [review]
Improve the register allocation for Float32ToDouble
Review of attachment 8347025 [details] [diff] [review]:
-----------------------------------------------------------------
Nice catch! That makes sense, since reads from Float32Array handled the conversion directly in assembly before and thus used the same register.
Thanks for investigating that!
Attachment #8347025 -
Flags: review?(benj) → review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 3•12 years ago
|
||
Assignee: nobody → dtc-moz
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
Nice!
|
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•