Use accessor methods for JSFunction fields

RESOLVED FIXED in mozilla29

Status

()

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

unspecified
mozilla29
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Assignee

Description

6 years ago
Posted patch patchSplinter Review
fun->nargs and fun->flags are public fields, and used during Ion compilation.  These should use accessor methods to add locking assertions and mark accesses on them as threadsafe.  The attached patch makes this change, and makes the remaining fields of JSFunction private (the big complicated union was still public though there are no accesses to it outside of JSFunction).
Attachment #8346901 - Flags: review?(jdemooij)
Attachment #8346901 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/c22a4358920a
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.