Closed Bug 949747 Opened 10 years ago Closed 10 years ago

Use accessor methods for JSFunction fields

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla29

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

patch
75.58 KB, patch
jandem
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
fun->nargs and fun->flags are public fields, and used during Ion compilation.  These should use accessor methods to add locking assertions and mark accesses on them as threadsafe.  The attached patch makes this change, and makes the remaining fields of JSFunction private (the big complicated union was still public though there are no accesses to it outside of JSFunction).
Attachment #8346901 - Flags: review?(jdemooij)
Attachment #8346901 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/c22a4358920a
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.