Closed
Bug 949747
Opened 11 years ago
Closed 11 years ago
Use accessor methods for JSFunction fields
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
75.58 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
fun->nargs and fun->flags are public fields, and used during Ion compilation. These should use accessor methods to add locking assertions and mark accesses on them as threadsafe. The attached patch makes this change, and makes the remaining fields of JSFunction private (the big complicated union was still public though there are no accesses to it outside of JSFunction).
Attachment #8346901 -
Flags: review?(jdemooij)
|
||
Updated•11 years ago
|
Attachment #8346901 -
Flags: review?(jdemooij) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c22a4358920a
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c22a4358920a
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•