949748 - [META] Modify Gaia apps to save memory by downsampling images while decoding when that feature is available

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[David Flanagan [:djf]]

Bug 854795 will hopefully give us a way to downsample images while decoding them so that when we have to deal with images that are larger than a mobile device screen we don't have to take the memory hit that comes with decoding them at full-size.

This will save huge amounts of memory, prevent OOMs, and make our apps more stable and quicker. This is especially true for the Gallery app (which will need a major refactoring).  But other Gaia apps should be modified to take advantage of the new feature, too:

The Music app can use the new API to create album art thumbnails.

The Contacts app can use the new API to resize contact photos.

The SMS app can use the new API to resize photos to be transferred by MMS.

The Wallpaper app can change its share activity handling to use the new feature.

This is a meta bug for keeping track of the various Gaia features that should be updated once 854795 is fixed.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

David, let's talk about a potential approach outlined in bug 951710.  Jeff is the right person on the graphics side.

Comment 2

[Nicholas Nethercote [inactive]]

We'll mark this as MemShrink:P1, and not mark the dependent bugs individually.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

We need to consider which of these dependent app bugs we want on tarako.  Nom'ing for 1.3t so that it shows up in the triage.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Ben Kelly [:bkelly] from comment #3)
> We need to consider which of these dependent app bugs we want on tarako. 
> Nom'ing for 1.3t so that it shows up in the triage.

We might want to just nominate the specific dependencies needed here. We don't typically block on meta bugs.

Comment 5

[[:fabrice] Fabrice Desré]

Don't we just want bug 945161?

Comment 7

[Inder]

Pinch and zoom in gallery is causing OOM issues on v1.4, not sure which dependent bug will fix the issue so noming this metabug for 2.0 since bug 990292 was made duplicate to this one. We should also try to fix it for v1.4 if possible.

Comment 8

[Mike Lee [:mlee]]

Hema,

Since we don't block on metas and most of this meta's dependencies are media issues do you plan to mark any of those dependencies as 2.0 blockers?

Bhavana,
Any guidance here?

Mike

Comment 9

[Hema Koka [:hema]]

(In reply to Mike Lee [:mlee] from comment #8)
> Hema,
> 
> Since we don't block on metas and most of this meta's dependencies are media
> issues do you plan to mark any of those dependencies as 2.0 blockers?
> 
> Bhavana,
> Any guidance here?
> 
> Mike

Not in the plan for 2.0 for other media apps. 

Gallery: Downsampling images when decoding and other OOM fixes on Gallery were implemented for 1.3T and there is a bug tracking the merge of those fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=1002593 (gallery). We plan to uplift it to 1.4 once the patch is r+ and landed on master.

Camera: Downsampling Camera merges to master is tracked here: https://bugzilla.mozilla.org/show_bug.cgi?id=1014955


Thanks
Hema

Comment 10

[bhavana bajaj [:bajaj]]

Clearing the nom as Hema's got this and the dependencies that we care about are blocking 1.4 already.

Comment 11

[Nicholas Nethercote [inactive]]

djf, what's the status here? Is there a next step?

Comment 12

[David Flanagan [:djf]]

Nicholas,

I think we're done here. I need to go through the dependent bugs and close them and close this.

Taking this bug so I remember to do that sometime.