949775 - UITelemetry should drop events on the floor if telemetry is disabled

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Richard Newman [:rnewman]]

No sense building up a big list of events that the user doesn't want to record or submit.

Comment 1

[Richard Newman [:rnewman]]

Attachment: UITelemetry should drop events on the floor if telemetry is disabled.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8346934 [details] [diff] [review]
UITelemetry should drop events on the floor if telemetry is disabled.

Just a note. Let's not add UITelemetry.uninit() because:
1. We don't want to add more to browser.js
2. Shutdown will likely never, ever be called in Fx for Android
3. We can just listen for "profile-before-change" which many JSMs use as a "shutdown is near" flag. Some XPCOM components use "xpcom-shutdown" but it fires late and I think "profile-before-change" is more typical for JSM/JS code.

https://developer.mozilla.org/en-US/docs/Observer_Notifications#Application_shutdown

Comment 3

[Richard Newman [:rnewman]]

(In reply to Mark Finkle (:mfinkle) from comment #2)

> 3. We can just listen for "profile-before-change" which many JSMs use as a
> "shutdown is near" flag.

WFM!

Comment 4

[Richard Newman [:rnewman]]

Attachment: UITelemetry should drop events on the floor if telemetry is disabled.

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8347029 [details] [diff] [review]
UITelemetry should drop events on the floor if telemetry is disabled.

Might as well put this in for review, save it from sitting here.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8347029 [details] [diff] [review]
UITelemetry should drop events on the floor if telemetry is disabled.

>diff --git a/toolkit/components/telemetry/UITelemetry.jsm b/toolkit/components/telemetry/UITelemetry.jsm

>+  observe: function(subject, topic, data) {

aSubject, aTopic and aData
(I know you dislike it, but it's the existing style in this file. You can curse me later.)

>+  uninit: function() {
>+  },

Remove

Comment 7

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/c4921ed6aef3

Comment 8

[Richard Newman [:rnewman]]

Preprocessing didn't work for some reason, so I backed this out.

https://hg.mozilla.org/integration/fx-team/rev/de09aa9a5c09

Comment 9

[Richard Newman [:rnewman]]

Relanded with UITelemetry.jsm added to the preprocessed module list.

https://hg.mozilla.org/integration/fx-team/rev/837203a4e076

Comment 10

[Phil Ringnalda (:philor)]

Backed out again in https://hg.mozilla.org/integration/fx-team/rev/23dffe2643bc for xpcshell bustage a la https://tbpl.mozilla.org/php/getParsedLog.php?id=32140627&tree=Fx-Team

Comment 11

[Phil Ringnalda (:philor)]

And robocop, https://tbpl.mozilla.org/php/getParsedLog.php?id=32142167&tree=Fx-Team

Comment 12

[Richard Newman [:rnewman]]

This time I even had a Try build.

https://hg.mozilla.org/integration/fx-team/rev/cb31b40dd8f3

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cb31b40dd8f3