94980 - Keyboard navigation in context menu causes highlight upon reopening

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[risto.kankkunen]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.3) Gecko/20010801
BuildID:    2001080110

You can have one or more menuitems appear highlighted, if you have used keyboard
to move around in a context menu first.


Reproducible: Always
Steps to Reproduce:
1. Open the context menu in browser
2. Use arrow keys to highlight a menu item
3. Press Esc to hide the context menu
4. Open the context menu again

Actual Results:  The item that was highlighted before you hid the menu still is
highlighted.


Expected Results:  None of the items should be highlighted.


Note: this is similar to bug 38425, although the trigger is different.

Comment 1

[RC]

Reproduced on WinXP 2001081108.

Comment 2

[Alfonso Martinez]

Confirming it with win98, build 2001081108
Marking as NEW and moving to XP Toolkit/Widgets: Menus

Comment 3

[:deanis74]

I'll take this one.  I wonder if the patch that I did at one time for 38425
(attachment 14653 [details] [diff] [review]) fixes this.

Comment 4

[:deanis74]

Attachment: why yes, yes it does

Comment 5

[:deanis74]

Really taking this time.

Comment 6

[:deanis74]

polish and an easy fix -->0.9.5

Comment 7

[:deanis74]

The patch I attached should fix any remaining "menu item remains highlighted on
re-open" bugs.  Looking for r=/sr=.

Comment 8

[John Morrison]

*** Bug 103971 has been marked as a duplicate of this bug. ***

Comment 9

[mdimitrio]

Additional comments to this bug report, from the report of bug 103971:

1. In step 2, the mouse pointer can be used in addition to the arrow keys.

2. This affects only the current window. If I have two Mozilla windows, do the
steps above on window 1, ALT+TAB to the next one (window 2) and call the context
menu, it'll appear just fine. When I return to the window 1, there's the messed
context menu.

3. This will go away when the user moves the mouse pointer (or keyboard arrow
keys) over the items.

Marcos.

Comment 10

[Asa Dotzler [:asa]]

0.9.5 is out the door. bumping TM up by one.

Comment 11

[:deanis74]

This didn't make 0.9.6.  Upping milestone.

Still looking for a review on this very simple cosmetic patch...

Comment 12

[Blake Ross]

Comment on attachment 45613 [details] [diff] [review]
why yes, yes it does

sr=blake

Comment 13

[:deanis74]

Thanks Blake.  Can someone check this in for me?

Comment 14

[Mike Pinkerton (not reading bugmail)]

r=pink

Comment 15

[:deanis74]

Attachment: cvs diff -u /layout/xul/base/src

New patch that works after the latest menu changes.  I guess I need to get
r=/sr= again, eh?  Any takers?	It would be nice to get this in before it rots
again.

Comment 16

[:deanis74]

I really don't want to push this off another milestone.  Review, please...
anyone??  The original patch was already reviewed, this latest patch is just
updated against the trunk.

Comment 17

[Brendan Eich [:brendan]]

You don't need re-review unless there have been substantive changes.  Have there
been any?

/be

Comment 18

[:deanis74]

Really?!  Well, no, there haven't been substantial changes, the patch is just
current with the tip.

Anyone care to check this in, then?

Comment 19

[:deanis74]

checked in