Closed Bug 949805 Opened 12 years ago Closed 7 years ago

[B2G][Browser][imgur.com]Share button on imgur.com does not function consistently.

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: rkuhlman, Unassigned)

References

()

Details

(Whiteboard: Dogfood1.2 [country-all])

Attachments

(4 files)

*note* This bug does NOT refer to the share button that is natively built into the Browser app. The website at www.imgur.com contains a share button built into the website. This share button does not function consistently. Tapping the share button prompts a selection reel to appear. The selection reel displays six options: Facebook, Reddit, Twitter, Tumblr, More Sharing Options, and Cancel. If the user taps on any of the websites on the reel, they are immediately taken to the login screen for that website. They are not required to press 'OK' to confirm the selection, and the browser does not open a new tab. Instead the browser navigates away from the original page to the user requested page. If the user selects 'More Sharing Options' and taps the 'OK' button, nothing happens. The reel is dismissed and the user is returned to the page. 'Cancel' exhibits the same functionality. Repro Steps: 1) Updated Buri 20131212004004 2) Launch Browser App. 3) Navigate to www.imgur.com. 4) Tap on an image to be taken to a gallery page. 5) Tap on the share button on the top of the screen. 6) Compare performance of different options in the share selection reel. Actual: Website share choices do not open a new tab, and do not require the user to confirm selection by tapping 'OK'. The 'More Sharing Options' selection is non-functional. Expected: After selecting a website to share to, user must confirm selection by tapping 'OK' button. The 'More Sharing Options' selection performs as expected. (Launch a new selection reel of phone based sharing options, or some similar behavior.) Environmental Variables Device: Buri v1.2 COM RIL Build ID: 20131212004004 Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/8bae10bb0aed Gaia: 6d02039072a2ae5cf9225a6f4c78ed49decfab5c Platform Version: 26.0 RIL Version: 01.02.00.019.102 Firmware Version: V1.2_20131115 Notes: Repro frequency 100% See attached screenshots and logcat.
Attached image ShareReel.png
Attached file logcat.txt
Issue also occurs in 1.1 Environmental Variables Device: Buri v1.1 COM RIL Build ID: 20131210041202 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/05117f42088f Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f Platform Version: 18.1 RIL Version: 01.01.00.019.281 Firmware Version: 20131115
Component: Gaia::Browser → Mobile
Product: Firefox OS → Tech Evangelism
on Firefox Android, I get the menu as a pop up list hovering the content of the window. When I click More sharing options, it redirects to addthis.com Web site. On Firefox OS 1.3, I get a menu as a pop up too. If I click on let's say twitter, it is opening a prepopulated form with the link to the image ready to be sent. Clicking "More sharing Options", turn the option as selected with a tick mark. Doing OK. doesn't do anything and it returns to the image itself.
Assignee: nobody → kdubost
Status: NEW → ASSIGNED
Flags: needinfo?(hsteen)
Whiteboard: Dogfood1.2 → Dogfood1.2 [country-all]
Attached file 949805.htm - TC
Flags: needinfo?(hsteen)
So the issue here is that they do window.open(url, '_blank') from a SELECT onchange event, and the browser seems to block this popup. Not sure why, since we don't do that on desktop.
Assignee: kdubost → nobody
Component: Mobile → Gaia::Browser
Product: Tech Evangelism → Firefox OS
I have not figured out why some of the options get selected immediately, without waiting for the OK button. The code makes an attempt to handle popup blocking by saying window.open(foo)||location.href=foo so that's why the windows you would expect the other options to open do not open and the current window is redirected instead. They just forgot to do this in the JS for the "more options" one. However, I don't see any reason why popup blocking should be stricter on device than on desktop, and it breaks this page, so I've moved the bug over to Firefox OS for investigation.
Firefox OS is not being worked on
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: