Closed Bug 949849 Opened 6 years ago Closed 5 years ago

B2G RIL: update the marionette test script for icc.updateContact

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(tracking-b2g:backlog, firefox40 fixed)

RESOLVED FIXED
2.2 S10 (17apr)
tracking-b2g backlog
Tracking Status
firefox40 --- fixed

People

(Reporter: allstars.chh, Assigned: jdai)

References

Details

(Whiteboard: [grooming])

Attachments

(1 file, 2 obsolete files)

In Bug 943234 there is a marionette test for icc.updateContact, but it didn't cover what Jose Manual met in https://bugzilla.mozilla.org/show_bug.cgi?id=943234#c29

So this bug is filed to fix that problem.
Add this in backlog.
blocking-b2g: --- → backlog
Whiteboard: [grooming]
blocking-b2g: backlog → ---
Assignee: nobody → jdai
This bug has been already resolved as Bug 943234[1].

[1]:https://bugzilla.mozilla.org/attachment.cgi?id=8339869&action=diff
Previous comment is wrong ticket. This patch make sure we won't return null in contact id. i.e. 8934071100275319295null.
Attachment #8584347 - Flags: review?(echen)
Comment on attachment 8584347 [details] [diff] [review]
Modify marionette test script for icc.updateContact.

Review of attachment 8584347 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for working on this. But this bug is filed for adding test for icc.updateContact, we should also test the result of icc.updateContact, too.

::: dom/icc/tests/marionette/test_icc_contact.js
@@ +48,5 @@
>            is(aResult.length, 5);
>  
>            is(aResult[4].name[0], "add");
>            is(aResult[4].tel[0].value, "0912345678");
> +          ok(!isNaN(parseInt(aResult[4].id)), "Should be a number " + aResult[4].id);

I think we should know the expected id of a new contact, e.g. iccid + number. Couldn't we just test aResult[4].id with it?
Attachment #8584347 - Flags: review?(echen)
This patch addresses comment 4.
Attachment #8584347 - Attachment is obsolete: true
Attachment #8585848 - Flags: review?(echen)
Attachment #8585848 - Flags: review?(echen)
Attachment #8585848 - Flags: review?(echen)
Comment on attachment 8585848 [details] [diff] [review]
Modify marionette test script for icc.updateContact. (V2)

Review of attachment 8585848 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.
Attachment #8585848 - Flags: review?(echen) → review+
Add reviewer r=echen.
Attachment #8585848 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/01b31307fb83
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S10 (17apr)
Blocks: 1157082
You need to log in before you can comment on or make changes to this bug.