949849 - B2G RIL: update the marionette test script for icc.updateContact

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In Bug 943234 there is a marionette test for icc.updateContact, but it didn't cover what Jose Manual met in https://bugzilla.mozilla.org/show_bug.cgi?id=943234#c29

So this bug is filed to fix that problem.

Comment 1

[Ken Chang[:kenkai]]

Add this in backlog.

Comment 2

[John Dai[:jdai]]

This bug has been already resolved as Bug 943234[1].

[1]:https://bugzilla.mozilla.org/attachment.cgi?id=8339869&action=diff

Comment 3

[John Dai[:jdai]]

Attachment: Modify marionette test script for icc.updateContact.

Previous comment is wrong ticket. This patch make sure we won't return null in contact id. i.e. 8934071100275319295null.

Comment 4

[Edgar Chen [:edgar]]

Comment on attachment 8584347 [details] [diff] [review]
Modify marionette test script for icc.updateContact.

Review of attachment 8584347 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for working on this. But this bug is filed for adding test for icc.updateContact, we should also test the result of icc.updateContact, too.

::: dom/icc/tests/marionette/test_icc_contact.js
@@ +48,5 @@
>            is(aResult.length, 5);
>  
>            is(aResult[4].name[0], "add");
>            is(aResult[4].tel[0].value, "0912345678");
> +          ok(!isNaN(parseInt(aResult[4].id)), "Should be a number " + aResult[4].id);

I think we should know the expected id of a new contact, e.g. iccid + number. Couldn't we just test aResult[4].id with it?

Comment 5

[John Dai[:jdai]]

Attachment: Modify marionette test script for icc.updateContact. (V2)

This patch addresses comment 4.

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8585848 [details] [diff] [review]
Modify marionette test script for icc.updateContact. (V2)

Review of attachment 8585848 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

Comment 7

[John Dai[:jdai]]

Attachment: Modify marionette test script for icc.updateContact. (Final), r=echen

Add reviewer r=echen.

Comment 8

[John Dai[:jdai]]

TryServer result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6612b41a360d

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/01b31307fb83

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/01b31307fb83