Closed
Bug 949877
Opened 12 years ago
Closed 11 years ago
[Dialer] Rework oncall transition to adapt incoming attention screen change.
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1068093
People
(Reporter: alive, Assigned: rexboy)
References
Details
Attachments
(1 file)
188 bytes,
text/html
|
Details |
See discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=927862
Comment 1•12 years ago
|
||
Recaping:
* The call screen should not be toggled anymore :) displayed directly and in a proper state
* We should start loading the wallpaper as soon as possible instead of waiting for onload
* We should remove the toggleScreen() function in CallsHandler in favor of an explicit closeScreen() function
We should pay special attention to:
* the opening and closing transition smoothness
* the call ended message
* the postMessage to save in the call log
Reporter | ||
Comment 2•12 years ago
|
||
Feel free to deassign if you're not available. (Discussed offline.)
Assignee: nobody → rexboy
Assignee | ||
Comment 3•12 years ago
|
||
A rough WIP:
https://github.com/rexboy7/gaia/commit/9ecce3e9072ddad5408275e04fa882e37e31b1c0#diff-d92153efec08c1bd2eb8540c4a6a8c31R350
We may try the performance of animation in system app with this WIP first.
Assignee | ||
Comment 4•12 years ago
|
||
This patch works on common use cases for me. I'm not sure if I did cleanup completely, so I'll continue look around and see if there's anything need to be cleaned.
Etienne we may need your feedback on this patch.. May you comment if there are any concerns. Thanks a lot!
Attachment #8350504 -
Flags: feedback?(etienne)
Comment 5•12 years ago
|
||
Comment on attachment 8350504 [details]
wip
Made a suggestion on the patch but I didn't had the system part of the patch to actually try this on a phone :)
Attachment #8350504 -
Flags: feedback?(etienne)
Reporter | ||
Comment 6•11 years ago
|
||
Rex, could you please finish this patch? I'd like to complete the attention-window patch.
Flags: needinfo?(rexboy)
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(rexboy)
You need to log in
before you can comment on or make changes to this bug.
Description
•