Closed Bug 949880 Opened 9 years ago Closed 9 years ago

Refactor android-sync SyncAdapter for re-use by FxAccountSyncAdapter

Categories

(Firefox for Android Graveyard :: Android Sync, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

(Whiteboard: [qa?])

Attachments

(1 file)

57 bytes, text/x-github-pull-request
nalexander
: review+
Details | Review
Bug 918012 wants to re-use a good deal of the Sync 1.1 SyncAdapter code.  This ticket is to land some re-factoring of SyncAdapter.
Attached file GitHub PR
This pull request is mis-labelled as Bug 918012 itself, but the first seven parts are going to land as this ticket.  This has already gotten r=rnewman on that GitHub PR.
Attachment #8347030 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/1b466d2cbf55
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Landed a slightly updated version.  Tested locally with default server (pair to existing account, multiple syncs), and I forced a node re-assignment-like path by deleting the local preferences.  There's no stage server standing, so I couldn't test it against a non-default server.  But I'm not too concerned that this patch will break that path.
https://hg.mozilla.org/mozilla-central/rev/1b466d2cbf55
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [qa?]
Cleaning up Resolved/Fixed bugs from December's first release.
Verified that we now have a working first-release of FxA to Desktop/Android Nightly.
Re-open as needed.
Status: RESOLVED → VERIFIED
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.