Refactor android-sync SyncAdapter for re-use by FxAccountSyncAdapter

VERIFIED FIXED

Status

()

VERIFIED FIXED
5 years ago
a year ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa?])

Attachments

(1 attachment)

Bug 918012 wants to re-use a good deal of the Sync 1.1 SyncAdapter code.  This ticket is to land some re-factoring of SyncAdapter.
(Assignee)

Comment 1

5 years ago
Created attachment 8347030 [details] [review]
GitHub PR

This pull request is mis-labelled as Bug 918012 itself, but the first seven parts are going to land as this ticket.  This has already gotten r=rnewman on that GitHub PR.
Attachment #8347030 - Flags: review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/1b466d2cbf55
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
Landed a slightly updated version.  Tested locally with default server (pair to existing account, multiple syncs), and I forced a node re-assignment-like path by deleting the local preferences.  There's no stage server standing, so I couldn't test it against a non-default server.  But I'm not too concerned that this patch will break that path.
https://hg.mozilla.org/mozilla-central/rev/1b466d2cbf55
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [qa?]
Cleaning up Resolved/Fixed bugs from December's first release.
Verified that we now have a working first-release of FxA to Desktop/Android Nightly.
Re-open as needed.
Status: RESOLVED → VERIFIED

Updated

a year ago
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.