949897 - test_cards_view_kill_apps_with_two_apps.py intermittently fails

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

Should not cause by https://travis-ci.org/mozilla-b2g/gaia/builds/15321988
and the test run well on my local try.

No idea.

Comment 1

[Anthony Ricaud (:rik)]

We're seeing this intermittent a lot. Do you mind if we disable it?

Comment 2

[Anthony Ricaud (:rik)]

I went ahead and disabled it for now. https://github.com/mozilla-b2g/gaia/commit/fa88c4e66760d9462ad6acd7b611eb64c9a917ce

Comment 3

[Zac C (:zac)]

This wasn't an intermittent yesterday and we didn't change the test so it's probably a real bug, if somebody could be bothered to investigate it.

Comment 4

[Zac C (:zac)]

Somebody investigate and re-enable this ASAP.

Comment 5

[Viorela Ioia [:viorela]]

I ran this test and I got 3 out of 21 fails: https://pastebin.mozilla.org/3789082
I will investigate the problem

Comment 6

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/14710

Comment 7

[Viorela Ioia [:viorela]]

I added a wait and I think it fixes the intermittent problem we had. But the thing is that I discovered another fail, before modifying the test. So I'll work on that one immediatelly. This is the fail I'm talking about https://pastebin.mozilla.org/3789554. 
I'll make a pull request once I fix it. I'll add it to this bug, since it still an intermittent fail.

Comment 8

[Zac C (:zac)]

(In reply to Viorela Ioia [:viorela] from comment #7)
> I added a wait and I think it fixes the intermittent problem we had. But the
> thing is that I discovered another fail, before modifying the test. So I'll
> work on that one immediatelly. This is the fail I'm talking about
> https://pastebin.mozilla.org/3789554. 
> I'll make a pull request once I fix it. I'll add it to this bug, since it
> still an intermittent fail.

The fail in the pastebin there is the one reported in this bug so I don't know what your patch is for!

Alive's original test failure has been over-written by the test run but I recall the exception message from memory (Alive next time copy/paste the exception?)

Comment 9

[[:AndreiH]]

After investigating this I added a time.sleep(3) before the 'holdhome' Javascript here:
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/system/regions/cards_view.py#L30
After 50+ runs on desktopb2g I got no fail
I think that the javascript is running to quickly.

Comment 10

[Zac C (:zac)]

AndreiH, could you replicate this *before* adding that sleep?

Comment 11

[[:AndreiH]]

Yes zac, I could replicate it and it was failing badly, even a time.sleep(1) would do the trick

Comment 12

[Zac C (:zac)]

I don't see why you can't just fix the Python wait that's in there?

Comment 13

[Zac C (:zac)]

Comment on attachment 8348036 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14710

r+ 
pls merge this when the tree re-opens :)

Comment 14

[Florin Strugariu [:Bebe]]

Merged:
https://github.com/mozilla-b2g/gaia/commit/e15a43c64a847a59f59f1fecfebd7762411a8363

Comment 15

[[:AndreiH]]

This bug was not resolved, the test is still disabled and we should also fix it for Travis
disabled = bug 949897 intermittently fails

Comment 16

[[:AndreiH]]

When I am seeing this fail, javascript "holdHome" is not really holding Home button, instead it just goes to Homescreen, like homescreen button was only tapped and Cards View is not opened. It just stays there in Homescreen waiting for cards view.

Comment 17

[Zac C (:zac)]

This is P1 because we want to re-enable the test.

Comment 18

[Zac C (:zac)]

Re-investigate enabling this by doing a long run on Travis, running it a few hundred times.

It's enabled for TBPL and is stable there.

Comment 19

[Zac C (:zac)]

Attachment: github pr

Let's re-enable this test, it's stable now.

Comment 20

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/a5ac8370d6f68c68263fdc7c4d85a759c11d1589

Comment 21

[Florin Strugariu [:Bebe]]

This test is failing on device:
http://qa-selenium.mv.mozilla.com:8080/job/b2g.hamachi.mozilla-central.ui/499/testReport/test_cards_view_kill_apps_with_two_apps/TestCardsViewTwoApps/test_kill_app_from_cards_view/

I will reopen the bug and we need to xfail it on device

Comment 23

[Zac C (:zac)]

https://github.com/mozilla-b2g/gaia/commit/c02a3f368cdc26efbda541e26a3b52318a9e80d1

Comment 24

[Zac C (:zac)]

Resolved.

there's a separate task to fix up the intermittent failure on this test.