949982 - [Gaia][DSDS] Fine tune SIM manager UI

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

SIM manager UI should follow the spec[1].

[1]: https://bugzilla.mozilla.org/attachment.cgi?id=8347148

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on github

Hi Fang,

can you help me review the UI for SimManager ? 

Thanks :D

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: screenshot.png

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: screenshot2.png

Comment 4

[Fang Shih [:fang]]

Comment on attachment 8356465 [details]
screenshot2.png

Hi Ej,

Good to go! Thanks for the effort!

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8356463 [details] [review]
patch on github

Hi Arthur,

just confirmed with Fang about the UI change and it looks nice to us. 

Please take sometime help me review this part (few styles change) when you have time. 

Big thanks !! :)

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8356463 [details] [review]
patch on github

Please check my comments regarding the item description in github. Thanks!

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8356463 [details] [review]
patch on github

Thanks Arthur, 

I just updated the code to make it do as what we did in `call settings`.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8356463 [details] [review]
patch on github

r=me. Thank you EJ!

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, 

landed on Gaia/master : e1688b6be665f2f25fb898c1809bf9f1efd10ce5