950072 - Metro "View Source" menu item should open a "child" tab

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1) Open several tabs in Metro.
2) Select the leftmost tab, and navigate to any web page.
3) Press the menu button in the navbar and choose "View page source."

Expected results: The source opens in a new tab next to the originally selected tab.  After closing the "view source" tab, the original tab is selected again.

Actual results: The source opens in a new tab at the far right of the tab strip.  After closing the "view source" tab, the rightmost tab is now selected.

This should be an easy fix; just change the BrowserUI.addAndShowTab call added in bug 849564 to pass "Browser.selectedTab" as the second parameter, the "owner" tab.

Comment 1

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug950072.patch

add selectedTab as second argument.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8347582 [details] [diff] [review]
bug950072.patch

Review of attachment 8347582 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Matt Brubeck (:mbrubeck)]

Landed on fx-team:
https://hg.mozilla.org/integration/fx-team/rev/5b9b8b25aa79

Since this is not a release blocker, it does not need to be uplifted to Firefox 28.  It should be fine to land for Firefox 29 because it's a one-line patch that will not cause any non-trivial uplift conflicts.

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5b9b8b25aa79

Comment 5

[Kamil Jozwiak [:kjozwiak]]

Went through the following issue with the latest Nightly/Aurora builds:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-12-00-40-02-mozilla-aurora/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-12-03-02-01-mozilla-central/

- Ensured that taping on "View page source" correctly opened a new "view-source" tab next to tab that spawned it
- Ensured that you can spawn multiple "view-source" tabs from the same website and they are correctly placed in the Tab App Bar
- Ensured that the "View page source" item is not available under "view-source" pages
- Ensured that you can close the "view-source" tabs without any issues
- Ensured that all of the above test cases worked under several different variations of snapped view