950085 - Don't toggle text-selection action-bar visibility changes on repositioning of cursor in inputs

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Aaron Train [:aaronmt]]

Currently when one repositions a cursor in an already focused editable input (e.g, a textarea) we toggle between dismissing the text-selection action-bar to reshowing the URL bar to reshowing the text-selection action-bar again which looks sloppy.

To reproduce: data:text/html,<textarea>this is a testcase</textarea>, tap to focus the field, tap again to invoke the text-selection action-bar, tap to reposition the cursor handle elsewhere within the text value

Expected: We keep the text-selection action-bar up
Actual: We flip between visibility

--
Aurora (28.0), Nightly (29.0) | LG Nexus 4 (Android 4.4.2)

Comment 1

[Mark Capella [:capella]]

I don't see this on a current nightly w/N7 w my Google Keyboard .. w/Swiftkbd I see the transition between actionbar /on then maybe back off if caret is lost due to autoComplete etc. like we discussed in bug 943944 comment #22 ...

Comment 2

[Aaron Train [:aaronmt]]

Screen-record from my Nexus 4 (Android 4.4.2): http://www.youtube.com/watch?v=UIHIn_A-vqs

Comment 3

[Wesley Johnston (:wesj)]

This looks to be keyboard dependent. i.e. every time you tap, your keyboard is throwing you into composition mode and then moving the cursor for us, which (for some reason?) causes us to throw away the caret. What keyboard is this?

Comment 4

[Aaron Train [:aaronmt]]

Stock Google Keyboard

Comment 5

[Mark Capella [:capella]]

In bug 927882 we're discussing the validity of throwing away the caret on compositionend key events.

This problem is quite noticeable on Swiftkey, but also as mentioned by aaronmt, also observable on Google Keyboard. 

I've yet to see these problems on Jellybean keyboard.

Comment 6

[Aaron Train [:aaronmt]]

Ping?

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Patch from bug 927882

This is the patch from bug 927882. It makes us not throw away the selection on compositionend events. margaret r+'d it there. It fixes this bug for me. Not sure of all the caveots involved though.

Comment 8

[Mark Capella [:capella]]

Comment on attachment 8370153 [details] [diff] [review]
Patch from bug 927882

Review of attachment 8370153 [details] [diff] [review]:
-----------------------------------------------------------------

I can only reproduce the original issue (aiui) when using the Swiftkeyboard, on both a GS3 and an N7. In this case, this patch does correct the navigation toolbar visibility flip, but introduces a regression where the caret can be left incorrectly positioned following auto-correction, etc. (This is the final issue why I wasn't able to finish bug 927882).

Testing on:
   GS3 w/Default (Samsung) and Jellybean keyboards...
   N7 w/Default (Google) and Jellybean keyboards...

I can't repro the original issue, and this patch has a neutral impact. The only thing I see in these before/after tests, is a brief flash of the icons in the actionbar, which is barely noticeable.

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8370153 [details] [diff] [review]
Patch from bug 927882

Review of attachment 8370153 [details] [diff] [review]:
-----------------------------------------------------------------

Canceling r? based on Mark's feedback. Also I'm not very familiar with this code. I think to get this right, we should first find some time to talk about interactions between text selection and IME in general.

Comment 11

[Aaron Train [:aaronmt]]

Any update here?

Comment 12

[Wesley Johnston (:wesj)]

We'll retest/revisit once some of the new IME patches have landed.

Comment 13

[Wesley Johnston (:wesj)]

Mark, do you think this is still happening? I'll try to test...

Comment 14

[Mark Capella [:capella]]

I believe the bug 927882 fixed this...  I observed positive results during testing iirc

Comment 15

[Aaron Train [:aaronmt]]

Forgot to verify this. Yes, this has resolved and is now working appropriately across the affected channels.