950143 - Remove the implicit conversion operator from nsIntSize to IntSize

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

This tends to cause double-copying; see e.g. bug 877115 comment 82 and the change in widget/gtk/nsWindow.cpp in this patch.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part 2

Someone added a lot of callers, probably enough to warrant another review.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part 3

*sigh*

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8351130 [details] [diff] [review]
Part 3

Review of attachment 8351130 [details] [diff] [review]:
-----------------------------------------------------------------

I think we need to move IntSize to the mozilla namespace. These gfx:: prefixes are ugly and pointless.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8351130 [details] [diff] [review]
Part 3

Review of attachment 8351130 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think we should scope-creep this bug to include that.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't like scope-creep either. The problem is that here you're adding a lot of namespace prefixes which uglify the code.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part 5: remove prefixes

I hope you appreciate this enough to make it worth the time.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8354951 [details] [diff] [review]
Part 5: remove prefixes

Review of attachment 8354951 [details] [diff] [review]:
-----------------------------------------------------------------

I do appreciate it, but use "using namespace mozilla::gfx;" instead of "using gfx::...;".

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/eea2c6adc544

Thanks.

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

And had to land

https://hg.mozilla.org/mozilla-central/rev/c71b40e7fab8

because

using namespace android;
using namespace mozilla::gfx;

makes `Size` ambiguous.