950147 - Add new Illustrative Wallpapers for v.1.4

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Comment 1

[Patryk Adamczyk [:patryk] UX]

Here is the link to all the wallpapers resized and compressed:
https://mozilla.box.com/s/ue0x8qq76seen8bfi83g
Can you please add these to the builds.

And remove the previous illustrated wallpapers:
+ FXOS_Illus_Blocks.png
+ [e-mail]
+ FXOS_Illus_Fox_Nature.png
+ [e-mail]
+ FXOS_Illus_Mountains.png
+ [e-mail]

The wallpapers are located here: https://github.com/mozilla-b2g/gaia/tree/master/apps/wallpaper/resources/320x480

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Hey Patryk,
can you check that PR? Hope that I don't miss something

Comment 3

[Patryk Adamczyk [:patryk] UX]

Overall looks good... but I don't see the @F1.5x, @2x @2.25x sizes. We need those added as well.
Thanks!

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks Patryk :) I added the rest of the images

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8374341 [details] [review]
patch for Gaia/master

Hey Vivien,

one more easy for review bug :)

Comment 6

[Patryk Adamczyk [:patryk] UX]

Looks good now, Pavel.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8374341 [details] [review]
patch for Gaia/master

Will it be possible to:
 - Remove the FXOS_Illus_ prefix for all wallpapers as it contains more or less some brand related name and that should not be.
 - Convert all the images to png and run the png_recompress.sh tool that lives in $GAIA/tools/png_recompress.sh in order to reduce the size of those images and remove extra headers.

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks Vivien :)

Hey Patryk
  1. Can we ramove the prefix?
  2. Can you give me the png versions of the wallpapers?

Thanks in advance :)

Comment 9

[Patryk Adamczyk [:patryk] UX]

Below is the link to the updated wallpapers.
https://mozilla.box.com/s/bp3zgg7dlv0s6u4w49su

1. For the sake of a less complex file, I removed "FXOS_Illus_" to just "IS_" I want to have all the wallpapers grouped by type... So we'll remove the prefix to the other ones in a bug coming in the next few days.
2. I already removed the extra headers by running a compressor, it made the files about 30% smaller than the original JPGs. They are about 50% smaller than the PNGs would be. I also adjusted the JPG compression to, there is quality loss but its not visible to most people, to maximize file size reduction.

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I need Vivien's opinion

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Patryk Adamczyk [:patryk] UX from comment #9)
> Below is the link to the updated wallpapers.
> https://mozilla.box.com/s/bp3zgg7dlv0s6u4w49su
> 
> 1. For the sake of a less complex file, I removed "FXOS_Illus_" to just
> "IS_" I want to have all the wallpapers grouped by type... So we'll remove
> the prefix to the other ones in a bug coming in the next few days.
> 2. I already removed the extra headers by running a compressor, it made the
> files about 30% smaller than the original JPGs. They are about 50% smaller
> than the PNGs would be. I also adjusted the JPG compression to, there is
> quality loss but its not visible to most people, to maximize file size
> reduction.

Is the jpg versus png size just a guess or have you actually tried ?

Comment 12

[Patryk Adamczyk [:patryk] UX]

I tried, and tried various compression methods.
ie. Mountains wallpaper @ 720p for Madia
JPG with a 10/12 compression - 310.9 kb
PNG - 712.2 kb

Now when I ran them through the image compressor (remove headers)
JPG - 255.6 kb (compressed 17.8%)
PNG - 669.4 kb (compressed 6.1%)

JPGs are always going to be smaller when you introduce a lot of colour.

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Patryk Adamczyk [:patryk] UX from comment #12)
> I tried, and tried various compression methods.
> ie. Mountains wallpaper @ 720p for Madia
> JPG with a 10/12 compression - 310.9 kb
> PNG - 712.2 kb
> 
> Now when I ran them through the image compressor (remove headers)
> JPG - 255.6 kb (compressed 17.8%)
> PNG - 669.4 kb (compressed 6.1%)
> 
> JPGs are always going to be smaller when you introduce a lot of colour.

Sounds good to me then. Lets do the PR without any reference to FXOS and that's fine to me.

Comment 14

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks Vivien :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/f9947d4854810b21a25a8bcd5c533efe67e34374