Closed
Bug 950338
Opened 12 years ago
Closed 12 years ago
[Cleopatra] Clean UI.js
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: alive, Assigned: alive)
Details
Attachments
(1 file, 1 obsolete file)
The ui.js now is in a messy state...it is just a too long file to understand.
Main issue:
1. Some classes are defined in the UI but some classes are out side.
2. Mass of global functions
I'm going to send a simple patch to refine (1) and do (2) in the followup to see if I could figure out a more semantic bootstrap procedure for cleopatra UI.
Attachment #8347609 -
Flags: review?(bgirard)
|
Assignee | |
Comment 1•12 years ago
|
||
Comment on attachment 8347609 [details] [review]
https://github.com/mozilla/cleopatra/pull/28
Bug found, lemme debug first -)
Attachment #8347609 -
Flags: review?(bgirard)
|
|
Assignee | |
Comment 2•12 years ago
|
||
The patch is try to demote the mass global functions and try to make each module has their own responsibility.
There's still ambiguous boundry between Cleopatra and AppUI but we could refine in the followup.
Attachment #8347609 -
Attachment is obsolete: true
Attachment #8347743 -
Flags: review?(bgirard)
|
||
Comment 3•12 years ago
|
||
Already merged. Thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Updated•12 years ago
|
Attachment #8347743 -
Flags: review?(bgirard) → review+
|
||
Updated•12 years ago
|
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•