950340 - resolve warning in security/nss/lib/certdb/

Status: RESOLVED DUPLICATE of bug 1182667

(NSS :: Libraries, defect)

Description

[Stefan Bogdan]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20131214121520

Steps to reproduce:

When i build, i found this warning :  In function ‘cert_CheckCertRevocationStatus’: crl.c:2688:27: warning: unused variable ‘rv2’ [-Wunused-variable] SECStatus rv2 = CERT_FindCRLEntryReasonExten(entry, &reason); . I resolved it removing rv2 variable. I also want to mention that this is my first commit and i want to learn this process.

Comment 1

[Stefan Bogdan]

Attachment: 950340.patch

This is my first patch. Please let me know if this is ok.

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8347614 [details] [diff] [review]
950340.patch

Review of attachment 8347614 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/nss/lib/certdb/crl.c
@@ +2684,5 @@
>                  rv = SECFailure;
>              }
>              if (SECFailure == rv)
>              {
> +                CERT_FindCRLEntryReasonExten(entry, &reason);

Thanks for the patch. Please use "(void) " to make it clear that we're purposely ignoring the return value.

Comment 3

[:Cykesiopka]

Looks like this was fixed as part of Bug 1182667:
https://hg.mozilla.org/projects/nss/diff/0a59f0bce2ea/lib/certdb/crl.c#l1.37

Thanks for the patch anyways.