Closed Bug 950352 Opened 9 years ago Closed 9 years ago

Fixed warning in mozilla-central/netwerk/srtp/src/crypto/kernel/alloc.c

Categories

(Core :: Networking, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: victor.ciurel, Assigned: victor.ciurel)

Details

Attachments

(1 file)

Attached patch first_warningSplinter Review
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131206145833

Steps to reproduce:

On build the following warning appeared: suggest braces around empty body in an ‘else’ statement. I placed braces on line 102 and also on line 77.


Actual results:

After building again, the warning disappered.


Expected results:

The warning should have disappeared.
Attachment #8347624 - Flags: review?(michal.novotny)
Comment on attachment 8347624 [details] [diff] [review]
first_warning

Note that the author metadata is incorrect: "# User Your Name <your.name@gmail.com>"
Attachment #8347624 - Attachment is patch: true
Comment on attachment 8347624 [details] [diff] [review]
first_warning

Review of attachment 8347624 [details] [diff] [review]:
-----------------------------------------------------------------

I suspect this should go upstream. jesup can decide
Attachment #8347624 - Flags: review?(michal.novotny) → review?(rjesup)
Comment on attachment 8347624 [details] [diff] [review]
first_warning

Review of attachment 8347624 [details] [diff] [review]:
-----------------------------------------------------------------

The patch should be uploaded to the libsrtp upstream for review there as well (https://github.com/cisco/libsrtp now)
Attachment #8347624 - Flags: review?(rjesup) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/a26827e1c3f3

Thanks for the patch! One request, can you please fix your hg configuration so your name isn't "Your Name <your.name@gmail.com>"? Thanks :)
Assignee: nobody → victor.ciurel
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a26827e1c3f3
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.