Closed Bug 950416 Opened 6 years ago Closed 6 years ago

test_background_blend_mode.html will be permaorange when 28 merges to beta

Categories

(Core :: Web Painting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29
Tracking Status
firefox26 --- unaffected
firefox27 --- unaffected
firefox28 + fixed
firefox29 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: philor, Assigned: olaru)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

https://tbpl.mozilla.org/?tree=Try&rev=9e4d891154f4 is current-aurora pushed to try as though it had been merged to beta. As the mochitest-5 (-8 for android, -1 for b2g desktop, -9 for b2g emulator) results show, since bug 841601 made background-blend-mode ifndef RELEASE_BUILD but didn't ifdef the tests, it's headed for permaorange on the next merge.
Assignee: nobody → olaru
I have added a check to the test to see if the flag is enabled, and skip value checks otherwise. I don't know if it is possible to skip the test entirely based on whether the property is disabled, so please let me know if there is a way to do that.

Phil - This patch is based on mozilla-central. I am not familiar with the procedure. Should I make another patch based on aurora?
Attachment #8358113 - Flags: review?(roc)
Attachment #8358113 - Flags: feedback?(philringnalda)
Flags: needinfo?(philringnalda)
Comment on attachment 8358113 [details] [diff] [review]
950416_fix_background_blend_mode_test.patch

Review of attachment 8358113 [details] [diff] [review]:
-----------------------------------------------------------------

You should use pushPrefEnv to enable the pref just for this test.
Attachment #8358113 - Flags: review?(roc) → review-
Hopefully this is better.
Attachment #8358113 - Attachment is obsolete: true
Attachment #8358113 - Flags: feedback?(philringnalda)
Attachment #8358126 - Flags: review?(roc)
You only need to create a separate patch when the trunk patch doesn't apply cleanly to aurora, and since the test hasn't changed at all since aurora branched, one patch will be fine.
Flags: needinfo?(philringnalda)
https://hg.mozilla.org/mozilla-central/rev/1979dd1a55d3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.