950416 - test_background_blend_mode.html will be permaorange when 28 merges to beta

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/?tree=Try&rev=9e4d891154f4 is current-aurora pushed to try as though it had been merged to beta. As the mochitest-5 (-8 for android, -1 for b2g desktop, -9 for b2g emulator) results show, since bug 841601 made background-blend-mode ifndef RELEASE_BUILD but didn't ifdef the tests, it's headed for permaorange on the next merge.

Comment 1

[Horia Iosif Olaru]

Attachment: 950416_fix_background_blend_mode_test.patch

I have added a check to the test to see if the flag is enabled, and skip value checks otherwise. I don't know if it is possible to skip the test entirely based on whether the property is disabled, so please let me know if there is a way to do that.

Phil - This patch is based on mozilla-central. I am not familiar with the procedure. Should I make another patch based on aurora?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8358113 [details] [diff] [review]
950416_fix_background_blend_mode_test.patch

Review of attachment 8358113 [details] [diff] [review]:
-----------------------------------------------------------------

You should use pushPrefEnv to enable the pref just for this test.

Comment 3

[Horia Iosif Olaru]

Attachment: 950416_fix_background_blend_mode_test_2.patch

Hopefully this is better.

Comment 4

[Phil Ringnalda (:philor)]

You only need to create a separate patch when the trunk patch doesn't apply cleanly to aurora, and since the test hasn't changed at all since aurora branched, one patch will be fine.

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1979dd1a55d3

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f60df68dc998

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1979dd1a55d3